[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev
- To: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
- From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
- Date: Thu, 13 Jul 2023 12:03:39 +0200
- Cc: Heiko Stübner <heiko@xxxxxxxxx>, Geert Uytterhoeven <geert+renesas@xxxxxxxxx>, Xinliang Liu <xinliang.liu@xxxxxxxxxx>, Linus Walleij <linus.walleij@xxxxxxxxxx>, Tomi Valkeinen <tomi.valkeinen+renesas@xxxxxxxxxxxxxxxx>, Alexey Kodanev <aleksei.kodanev@xxxxxxxxxxx>, dri-devel@xxxxxxxxxxxxxxxxxxxxx, Vandita Kulkarni <vandita.kulkarni@xxxxxxxxx>, Alim Akhtar <alim.akhtar@xxxxxxxxxxx>, Anitha Chrisanthus <anitha.chrisanthus@xxxxxxxxx>, Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx>, Jonathan Hunter <jonathanh@xxxxxxxxxx>, Arun R Murthy <arun.r.murthy@xxxxxxxxx>, Jerome Brunet <jbrunet@xxxxxxxxxxxx>, Liu Shixin <liushixin2@xxxxxxxxxx>, linux-samsung-soc@xxxxxxxxxxxxxxx, Samuel Holland <samuel@xxxxxxxxxxxx>, Matt Roper <matthew.d.roper@xxxxxxxxx>, Wenjing Liu <wenjing.liu@xxxxxxx>, Javier Martinez Canillas <javierm@xxxxxxxxxx>, Stanislav Lisovskiy <stanislav.lisovskiy@xxxxxxxxx>, Danilo Krummrich <dakr@xxxxxxxxxx>, NXP Linux Team <linux-imx@xxxxxxx>, spice-devel@xxxxxxxxxxxxxxxxxxxxx, Niranjana Vishwanathapura <niranjana.vishwanathapura@xxxxxxxxx>, linux-sunxi@xxxxxxxxxxxxxxx, Stylon Wang <stylon.wang@xxxxxxx>, Tim Huang <Tim.Huang@xxxxxxx>, Suraj Kandpal <suraj.kandpal@xxxxxxxxx>, André Almeida <andrealmeid@xxxxxxxxxx>, Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx>, Yifan Zhang <yifan1.zhang@xxxxxxx>, Leo Li <sunpeng.li@xxxxxxx>, Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>, Lucas De Marchi <lucas.demarchi@xxxxxxxxx>, Inki Dae <inki.dae@xxxxxxxxxxx>, Hersen Wu <hersenxs.wu@xxxxxxx>, Jessica Zhang <quic_jesszhan@xxxxxxxxxxx>, Kamlesh Gurudasani <kamlesh.gurudasani@xxxxxxxxx>, Bhawanpreet Lakha <Bhawanpreet.Lakha@xxxxxxx>, Łukasz Bartosik <lb@xxxxxxxxxxxx>, Radhakrishna Sripada <radhakrishna.sripada@xxxxxxxxx>, Andrew Jeffery <andrew@xxxxxxxx>, Seung-Woo Kim <sw0312.kim@xxxxxxxxxxx>, Noralf Trønnes <noralf@xxxxxxxxxxx>, kernel@xxxxxxxxxxxxxx, Alex Deucher <alexander.deucher@xxxxxxx>, freedreno@xxxxxxxxxxxxxxxxxxxxx, Claudiu Beznea <claudiu.beznea@xxxxxxxxxxxxx>, Zack Rusin <zackr@xxxxxxxxxx>, Gerd Hoffmann <kraxel@xxxxxxxxxx>, Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>, linux-aspeed@xxxxxxxxxxxxxxxx, nouveau@xxxxxxxxxxxxxxxxxxxxx, Mitul Golani <mitulkumar.ajitkumar.golani@xxxxxxxxx>, José Roberto de Souza <jose.souza@xxxxxxxxx>, virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx, Thierry Reding <thierry.reding@xxxxxxxxx>, Yongqin Liu <yongqin.liu@xxxxxxxxxx>, Mario Limonciello <mario.limonciello@xxxxxxx>, Fei Yang <fei.yang@xxxxxxxxx>, Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>, David Lechner <david@xxxxxxxxxxxxxx>, Juha-Pekka Heikkila <juhapekka.heikkila@xxxxxxxxx>, "Jiri Slaby (SUSE)" <jirislaby@xxxxxxxxxx>, David Francis <David.Francis@xxxxxxx>, Aaron Liu <aaron.liu@xxxxxxx>, Patrik Jakobsson <patrik.r.jakobsson@xxxxxxxxx>, Vinod Polimera <quic_vpolimer@xxxxxxxxxxx>, linux-rockchip@xxxxxxxxxxxxxxxxxxx, Fangzhi Zuo <jerry.zuo@xxxxxxx>, Aurabindo Pillai <aurabindo.pillai@xxxxxxx>, VMware Graphics Reviewers <linux-graphics-maintainer@xxxxxxxxxx>, Ben Skeggs <bskeggs@xxxxxxxxxx>, Jouni Högander <jouni.hogander@xxxxxxxxx>, Dave Airlie <airlied@xxxxxxxxxx>, linux-mips@xxxxxxxxxxxxxxx, Maxime Coquelin <mcoquelin.stm32@xxxxxxxxx>, Gurchetan Singh <gurchetansingh@xxxxxxxxxxxx>, Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>, linux-arm-msm@xxxxxxxxxxxxxxx, Animesh Manna <animesh.manna@xxxxxxxxx>, linux-renesas-soc@xxxxxxxxxxxxxxx, Maxime Ripard <mripard@xxxxxxxxxx>, Chaitanya Kumar Borah <chaitanya.kumar.borah@xxxxxxxxx>, Biju Das <biju.das.jz@xxxxxxxxxxxxxx>, linux-amlogic@xxxxxxxxxxxxxxxxxxx, Evan Quan <evan.quan@xxxxxxx>, Michal Simek <michal.simek@xxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, Sean Paul <sean@xxxxxxxxxx>, Neil Armstrong <neil.armstrong@xxxxxxxxxx>, Kai Vehmanen <kai.vehmanen@xxxxxxxxxxxxxxx>, Boris Brezillon <bbrezillon@xxxxxxxxxx>, Chunyan Zhang <zhang.lyra@xxxxxxxxx>, Qingqing Zhuo <qingqing.zhuo@xxxxxxx>, Sandy Huang <hjc@xxxxxxxxxxxxxx>, Swati Sharma <swati2.sharma@xxxxxxxxx>, John Stultz <jstultz@xxxxxxxxxx>, Paul Kocialkowski <paul.kocialkowski@xxxxxxxxxxx>, Kyungmin Park <kyungmin.park@xxxxxxxxxxx>, Drew Davenport <ddavenport@xxxxxxxxxxxx>, Kevin Hilman <khilman@xxxxxxxxxxxx>, Hawking Zhang <Hawking.Zhang@xxxxxxx>, Haneen Mohammed <hamohammed.sa@xxxxxxxxx>, Anusha Srivatsa <anusha.srivatsa@xxxxxxxxx>, Dan Carpenter <error27@xxxxxxxxx>, Karol Herbst <kherbst@xxxxxxxxxx>, Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>, linux-hyperv@xxxxxxxxxxxxxxx, Stefan Agner <stefan@xxxxxxxx>, Melissa Wen <melissa.srw@xxxxxxxxx>, Maíra Canal <mairacanal@xxxxxxxxxx>, Luca Coelho <luciano.coelho@xxxxxxxxx>, Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>, Andrzej Hajda <andrzej.hajda@xxxxxxxxx>, Likun Gao <Likun.Gao@xxxxxxx>, Sam Ravnborg <sam@xxxxxxxxxxxx>, Alain Volmat <alain.volmat@xxxxxxxxxxx>, Xinwei Kong <kong.kongxinwei@xxxxxxxxxxxxx>, Jernej Skrabec <jernej.skrabec@xxxxxxxxx>, Deepak Rawat <drawat.floss@xxxxxxxxx>, Chen-Yu Tsai <wens@xxxxxxxx>, Joel Stanley <joel@xxxxxxxxx>, Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>, Ankit Nautiyal <ankit.k.nautiyal@xxxxxxxxx>, Harry Wentland <harry.wentland@xxxxxxx>, Sumit Semwal <sumit.semwal@xxxxxxxxxx>, Alan Liu <haoping.liu@xxxxxxx>, Philip Yang <Philip.Yang@xxxxxxx>, Lyude Paul <lyude@xxxxxxxxxx>, intel-gfx@xxxxxxxxxxxxxxxxxxxxx, Alison Wang <alison.wang@xxxxxxx>, Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>, Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>, Gustavo Sousa <gustavo.sousa@xxxxxxxxx>, Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx>, Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>, Mikko Perttunen <mperttunen@xxxxxxxxxx>, Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxxxxxxxx>, Rodrigo Siqueira <rodrigosiqueiramelo@xxxxxxxxx>, Tomi Valkeinen <tomba@xxxxxxxxxx>, Deepak R Varma <drv@xxxxxxxxx>, "Pan, Xinhui" <Xinhui.Pan@xxxxxxx>, Chia-I Wu <olvaffe@xxxxxxxxx>, Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>, Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>, Tian Tao <tiantao6@xxxxxxxxxxxxx>, Shawn Guo <shawnguo@xxxxxxxxxx>, Christian König <christian.koenig@xxxxxxx>, Khaled Almahallawy <khaled.almahallawy@xxxxxxxxx>, linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx, Emma Anholt <emma@xxxxxxxxxx>, Chun-Kuang Hu <chunkuang.hu@xxxxxxxxxx>, Imre Deak <imre.deak@xxxxxxxxx>, Liviu Dudau <liviu.dudau@xxxxxxx>, Alexandre Torgue <alexandre.torgue@xxxxxxxxxxx>, Roman Li <roman.li@xxxxxxx>, Paul Cercueil <paul@xxxxxxxxxxxxxxx>, Rob Clark <robdclark@xxxxxxxxx>, Hamza Mahfooz <hamza.mahfooz@xxxxxxx>, David Airlie <airlied@xxxxxxxxx>, Marek Vasut <marex@xxxxxxx>, Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Guchun Chen <guchun.chen@xxxxxxx>, Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>, Raphael Gallais-Pou <raphael.gallais-pou@xxxxxxxxxxx>, Rodrigo Siqueira <Rodrigo.Siqueira@xxxxxxx>, Russell King <linux@xxxxxxxxxxxxxxx>, Jani Nikula <jani.nikula@xxxxxxxxx>, Uma Shankar <uma.shankar@xxxxxxxxx>, Mika Kahola <mika.kahola@xxxxxxxxx>, Jiasheng Jiang <jiasheng@xxxxxxxxxxx>, Srinivasan Shanmugam <srinivasan.shanmugam@xxxxxxx>, Thomas Zimmermann <tzimmermann@xxxxxxx>, Vinod Govindapillai <vinod.govindapillai@xxxxxxxxx>, linux-tegra@xxxxxxxxxxxxxxx, Marek Olšák <marek.olsak@xxxxxxx>, Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>, Joaquín Ignacio Aramendía <samsagax@xxxxxxxxx>, Melissa Wen <mwen@xxxxxxxxxx>, Hans de Goede <hdegoede@xxxxxxxxxx>, linux-mediatek@xxxxxxxxxxxxxxxxxxx, Fabio Estevam <festevam@xxxxxxxxx>, Laurentiu Palcu <laurentiu.palcu@xxxxxxxxxxx>, Matthias Brugger <matthias.bgg@xxxxxxxxx>, David Tadokoro <davidbtadokoro@xxxxxx>, AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>, Orson Zhai <orsonzhai@xxxxxxxxx>, amd-gfx@xxxxxxxxxxxxxxxxxxxxx, Jyri Sarha <jyri.sarha@xxxxxx>, Yannick Fertre <yannick.fertre@xxxxxxxxxxx>, Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx>, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>, Philippe Cornu <philippe.cornu@xxxxxxxxxxx>, Daniel Vetter <daniel@xxxxxxxx>, Wayne Lin <Wayne.Lin@xxxxxxx>, Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>, Nirmoy Das <nirmoy.das@xxxxxxxxx>, Lang Yu <Lang.Yu@xxxxxxx>, Lucas Stach <l.stach@xxxxxxxxxxxxxx>
- Delivery-date: Thu, 13 Jul 2023 10:43:49 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Jul 13, 2023 at 08:52:12AM +0200, Geert Uytterhoeven wrote:
> Hi Uwe,
>
> Let's add some fuel to keep the thread alive ;-)
>
> On Wed, Jul 12, 2023 at 6:13 PM Uwe Kleine-König
> <u.kleine-koenig@xxxxxxxxxxxxxx> wrote:
> > On Wed, Jul 12, 2023 at 05:34:28PM +0300, Jani Nikula wrote:
> > > I think this is an unnecessary change. In drm, a dev is usually a drm
> > > device, i.e. struct drm_device *.
> >
> > Well, unless it's not. Prominently there is
> >
> > struct drm_device {
> > ...
> > struct device *dev;
> > ...
> > };
> >
> > which yields quite a few code locations using dev->dev which is
> > IMHO unnecessary irritating:
> >
> > $ git grep '\<dev->dev' v6.5-rc1 drivers/gpu/drm | wc -l
> > 1633
>
> I find that irritating as well...
>
> Same for e.g. crtc->crtc.
>
> Hence that's why I had sent patches to rename the base members in the
> shmob_drm-specific subclasses of drm_{crtc,connector,plane} to "base".
> https://lore.kernel.org/dri-devel/b3daca80f82625ba14e3aeaf2fca6dcefa056e47.1687423204.git.geert+renesas@xxxxxxxxx
>
> > Also the functions that deal with both a struct device and a struct
> > drm_device often use "dev" for the struct device and then "ddev" for
> > the drm_device (see for example amdgpu_device_get_pcie_replay_count()).
>
> I guess you considered "drm_dev", because it is still a short name?
I considered drm_dev because it is still moderately short and a good
approximation of "drm_device". Other than that the main driving force to
pick "drm_dev" was that it's unique enough that I could have done
s/\<drm_dev\>/$nameofchoice/ on the initial patch and get it mostly
right.
> Code dealing with platform devices usually uses "pdev" and "dev".
> Same for PCI drivers (despite "pci_dev" being a short name).
pci_dev and platform_device both typlically using pdev already annoyed
me in the past. However less than drm_device *dev because for pci_dev +
platform_device there is little overlap.
> So my personal preference goes to "ddev".
I sticked to "drm" for the new series. I think this provides less fuel.
Best regards and thanks for your thoughts,
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
|