[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] ns1650: refactor interrupt handling in ns16550_uart_dt_init()


  • To: Oleksii <oleksii.kurochko@xxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 13 Jul 2023 16:26:29 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cng//jCHET8mynMMMnrbIUc34ilas+gWD2Q8e9FqTvI=; b=hWHVHoyBtiUJfIOazCE3lYs7R1QkWCg8zB1s5xbmBHMQ2sDlM3mXuG76qttTYZraj4RT8nr1vXOXDH9PnUX9t7e/WtuRFSvI0gTn8E9gaiJ/R7DMZR5cE1eK3F3xMheHMKn8sJSZYca5MatTH9oIt/eCxLoYFAN2c7+wL2n2BaIUYwQi+fVKGqhyJxwMZKOkXKSZbTxDZmnqqSd2V0mWMNu02tgm383YpmPZTdhBBRPS3lNjTfBHw9BaQXCncqJGyLy1A35Io483bNyYqWeIJYOdjRv8dJivJiRqyuRIANNi34PEj3+oAS9gQr+3R+FmoRRiSh+aDwmOklEaOZF7ng==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cUCZJxGC0za5SoRGoC03vtKU/OcVZd15bodirs4zuV0tFSatitavYNDKdCCeP3uFsLDANeGNWSxIsmGyUQzsnCUdQxIfVx1FOux6timHyAFlVuTXyJidulGPlqGyR1HJg4GDvyh1ClO+lUXTti4P21nstZgY54+b98LWJD7msfkuY8TnmwGvyCnm2Gsw+qfEMH2Ut0zZ4LOU235jQOyHOcqRySi/roUBJxZPsy46jIYx94v8ch5VWUPgA9fuhhjQasmyeutJnxxVrHJgrOQ5MH9RPMfGU+MiyD2T57N6i0sbED1fO+wDfxXN3oEgWeI0qhMziBgYqkH+0sDJ/OEyMA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Julien Grall <julien@xxxxxxx>
  • Delivery-date: Thu, 13 Jul 2023 14:26:45 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 13.07.2023 15:36, Oleksii wrote:
> On Thu, 2023-07-13 at 15:27 +0200, Jan Beulich wrote:
>> I don't understand. My earlier comment was affecting all checks of
>> uart->irq alike, as I'm unconvinced IRQ0 may not possibly be usable
>> on some architecture / platform. IOW I don't see why the check in
>> ns16550_init_postirq() would allow us any leeway.
> It looks like I misunderstood you.
> 
> Do you mean that on some architecture IRQ0 may be used for ns16550?

Yes, I don't see why this shouldn't be possible in principle. As Julien
said it can't happen on Arm, so if it also can't happen on RISC-V and
PPC, we could elect to continue to ignore that aspect.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.