[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH] x86/mce: change parameter names in function definitions to match the corresponding declarations
- To: Federico Serafini <federico.serafini@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 14 Jul 2023 10:42:06 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/1pb0GgA5M+V5KbnFMx4YxRFANsacuU+kNapv3ZEn48=; b=HuXLYuIPm60SllZDMeA8KiIxKXkbk7z0O3rXDkNnw3IIm84G6qWk0XSfNggu4XMEdWkPY56hcx0Paa+JaQ3rZ0XDKZK52no+WmiXGngQpQ5yjfTPbzrAX9D1znDMwMPlTGqAV9wRbpdg/mfpT5Ye6MKA9mehXqYvnwx/K4nnhEK88mcFzF2lCK9Pp89uzWkgJQLlYX3/8Py4j1CQA+90VggH3ngnHJEhO9EBJ1KFhpZEZCEkNPJeB2QTj3Bh4xVDVCCTqom/FMLgWNJcsiyl2i5EuLNbMN4fCn7Xxa+5lRmtlvZomFuhddSopORWkLxMeiaFHMcAIx6aYzymVuLtsw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k3Zb+Gk3knxNi3F4OAMZZyWXr0SMW6xHf3TOqHb2baPpjoXZC4AAcy/kLrFcFfwMvBwB1bK9b3Oopo0oKXP0szFICuS46mSAYVT6bLLUz6ZPS7LMWwGn3RQ1OY35huSgrdqnpiJ+ckkPc9UPVYN8feVjZ7YEc+2YwYai5f3taQfCM53Qal9raI2sQ1jKb9AJeXr+IDSOfILDd9CZWvz83MVPJkZZMezY78fsh3Rm+STagIMQ7rAR2jnxO5pDxkpt/nsQ7TkcorAeR7tMYKAYriGd67WkbNVQwZ9KgShEIt1ygxyUP/RF3mCPrKiRztqOwU7hrD66fiWJD6Zpu9SYZQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: consulting@xxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Xenia Ragiadakou <xenia.ragiadakou@xxxxxxx>, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 14 Jul 2023 08:42:39 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 14.07.2023 10:10, Federico Serafini wrote:
> Change parameter names in function definitions to match the
> corresponding delcarations thus fixing violations of MISRA C:2012
> Rule 8.3 ("All declarations of an object or function shall use the same
> names and type qualifiers").
>
> Signed-off-by: Federico Serafini <federico.serafini@xxxxxxxxxxx>
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
Would have been nice if ...
> --- a/xen/arch/x86/cpu/mcheck/mce_amd.c
> +++ b/xen/arch/x86/cpu/mcheck/mce_amd.c
> @@ -272,13 +272,13 @@ int vmce_amd_rdmsr(const struct vcpu *v, uint32_t msr,
> uint64_t *val)
> }
>
> enum mcheck_type
> -amd_mcheck_init(struct cpuinfo_x86 *ci)
> +amd_mcheck_init(struct cpuinfo_x86 *c)
... const had been added here on this occasion; I may take the liberty
of doing so while committing.
Jan
|
