[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH 2/4] xen/arm64: bitops: justify uninitialized variable inside a macro

To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
From: Julien Grall <julien@xxxxxxx>
Date: Fri, 14 Jul 2023 14:05:03 +0100
Cc: sstabellini@xxxxxxxxxx, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
Delivery-date: Fri, 14 Jul 2023 13:05:09 +0000
List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Hi,

On 14/07/2023 12:49, Nicola Vetrini wrote:

The macro 'testop' expands to a function that declares the local
variable 'oldbit', which is written before being set, but is such a
way that is not amenable to automatic checking.

The code is pretty straightforward. So I am not entirely sure why Eclairis not happy. Is it because the value is set by assembly code?


Cheers,

--
Julien Grall

Follow-Ups:
- Re: [RFC PATCH 2/4] xen/arm64: bitops: justify uninitialized variable inside a macro
  - From: Luca Fancellu

References:
- [RFC PATCH 0/4] fix some issues related to MISRA C:2012 Rule 9.1
  - From: Nicola Vetrini
- [RFC PATCH 2/4] xen/arm64: bitops: justify uninitialized variable inside a macro
  - From: Nicola Vetrini

Prev by Date: [PATCH] xen/ACPI: Remove the acpi_string type
Next by Date: [PATCH] xen/ACPI: Use const char * for string literals
Previous by thread: [RFC PATCH 2/4] xen/arm64: bitops: justify uninitialized variable inside a macro
Next by thread: Re: [RFC PATCH 2/4] xen/arm64: bitops: justify uninitialized variable inside a macro
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.