[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/ioapic: sanitize IO-APIC pins before enabling the local APIC
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Fri, 14 Jul 2023 18:05:42 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=twUQE7mTHxFLPlFtAgbZTzifOVeNNyhHf9eIklb82fo=; b=RBESy6eXNRp6baRBV68kWq6iM/JyQwPSqMAPo5yMz85kOjuRiCGjOWUdw3p7SQu8XFg0X0sXGGv/uM3fT8OQNRKzo7UyxKLh2kTgPgQQS0fzeY4pcq14ahOnJCuEEJzIFfmkOiwOnx9SrrMGmrHNpdLtSBL7lcaFDrwnLKfTB025tZY7LjGiCE1rXupiNhxQjvOCmtnh+BtYMS73A3bzNP29izaYH63onOLDFGNl/4QCvC2NBDZKWFxHUyJufZwJaJTHzasaZQUDy7QtomgQicm2cnkPAdcHX1uj6Ajs0EU1yIc/IKxV6ncimw/9c4LZtI3ouVS7X/n3trXdZrhROQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j6fpsVqo8N+6HEZS/dQ6Cy6P/Ig6NeHiyH1UleLLeeRdDmZ6oO2vnSr9mvOnTSwiLXnlo0KLnxuwW9cW5ytMG2MR8tie0eY4Urx4zMNa0C9OrPReAO23cOUUuJiIYM5csYm6BNyXvsq3d3EoQlkmywkWsuKyz4vrCYFJ8qz9oYQvN8gG06d711Yz4oYwHgHHOchmeCM8HMWkcdzJZDSwotMTT+xLKPm8jouLTYB9NPJ6lAVilzaBdjJAVu73DMJsKJu0mEX7Vym/wYb8OpDyAX1oHi7ZJSLu+ZIVNsY39LUSdPe53BeCO/M8MOfh7BHZd5b/Uslrip8bC3owzzITOA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 14 Jul 2023 16:06:10 +0000
- Ironport-data: A9a23:87ClVqmJ3nHThk4x5uopxEPo5gynJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIfXGHTMqrYYjOgKY8naYy/9UsBvZGBytFqSFdr+HwyESMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE0p5K2aVA8w5ARkPqgU5QOGzhH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 c4mCDlOVT6pvd2V7J3lUdFXuZ4+b9a+aevzulk4pd3YJdAPZMmaBonvu5pf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVM3iea8WDbWUoXiqcF9hEGXq 3iA523kKhobKMae2XyO9XfEaurnxHqmBd9KS+XmnhJsqAXPwks2LRoZb2GQrtuWuw2yVulwc 1NBr0LCqoB3riRHVOLVXRe1vXqFtR40QMdLHqsx7wTl4rXQyxaUAC4DVDEpQMwrsoo6SCIn0 neNnsj1Hnp/vbuNU3Wf+7yI6zSoNkAowXQqYCYFSU4J5oflqYRq1xbXFI89Qeiyk8H/Hiz2z 3aSti8iir4PjMkNkaKm4VTAhDHqrZ/MJuIo2jjqsquexlsRTOaYi0aAsDA3Md4owF6lc2S8
- Ironport-hdrordr: A9a23:SZiS7606G7dVVCD2XHSLeAqjBJkkLtp133Aq2lEZdPU1SL38qy nKpp536faaslossR0b9uxoQZPwOE80lqQFg7X5X43DYOCOggLBEGgF1+XfKlbbak7DH4BmtJ uIRJIObOEYXWIQsS8j2njCLz/7+qjgzEl0v5a4856wd3ATV0i/1XYCNjqm
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Jul 13, 2023 at 02:18:29PM +0200, Jan Beulich wrote:
> On 13.07.2023 13:29, Roger Pau Monné wrote:
> > So to recap, I think we are in agreement that calling enable_IO_APIC()
> > just ahead of the call to setup_local_APIC() is the preferred
> > solution?
>
> Well, yes and no. My preferred course of action for the issue at hand
> would be to convert RTE 0 to ExtInt (under the mentioned set of
> conditions). I agree though that we also want to move the masking of
> RTEs, and for that I further agree with the placement mentioned above.
So I hacked up a change to set pin 0 to ExtINT mode (and avoid doing
the masking early), and I got:
(XEN) spurious 8259A interrupt: IRQ7.
This was a single interrupt, but still I think the masking is the
critical part to get backported.
Thanks, Roger.
|
