[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Experiments with clang-format and exclude-list.json
- To: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 18 Jul 2023 11:43:39 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qWUctEVPj/d7E/ZshGeF44eB425yKRCLn5zMjV0kx3s=; b=bcW9EM5v5J0Q4u0RAOezRpSvEdM5gEXtSBEgTMyyb9LySLUAU1EU6PiiGO//Z+wLvIYS/FC8ZZOsKYUW8GA/hPgCoJjNvIjqdPJWjkkDxY9AUKeDPyZMaiAn+U/5hHxQR9eGUv3lKPE2LmbcMP0j+tZyLc6DzAbR4xK3TtZU76W5A4XpjA4UAH49AMvGXQ3jHoiyAlH9/TcZ74fUDYIxPf+gcN6i4FBr+CalUFyOfraihsDYGJ6eUGWsSrzMx54d9oBqnQgY1Em5bL+8YMAy8h9nzeJrCZ6lr7oJrkzQVqxGwJXDvnA0hV7BJlCzmpCYD3MLKYe7QkLWQhkgKcihmg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zyt9m3FLMEqr/8WBvX9uqde/JDz5r0yL+k8PG0ajTnXqHsWODELj2urDvzo8ca5b6uZ+LRR8CCsMKkbVgZJM3luaLiJzCM7Wz6bx+7+rAxgIKOILRkxgAEKZ3kK5t+WfuTQZWJlIoSIaccq8un5D+6KnPQkVJ52skNM23+vtyznvRu+ksbz9PcoxZ7e4umPi5V50vJ0riDU+vqplOz0kKwwMwR/69wZ/PXmYlG6welvD5t9cliMb/Og/dbkF3havoRgGbSU+05XmZ/tJM5SSFbxdKpjzRgNZ8qVa7m4m1mXpW25x77M1ey9efZlyKTOHbdu7GBQpEEkHafqU7UsR+g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 18 Jul 2023 09:43:50 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 18.07.2023 11:13, Luca Fancellu wrote:
> I’ve done some experiment with clang-format and the hypervisor code
> (xen/xen/**), I had the need to exclude some files from the tool
> and I thought to use the exclude-list.json, but since it was intended for
> MISRA, I’m now asking your feedback about that.
>
> In my opinion it could make sense, because with that list we are excluding
> everything that is external and not adopting the Xen
> coding style.
>
> Do you have an opinion on that? Can it be one file? Or should it be a
> separate file only for the coding style exclusion?
It feels like back when the file was introduced I already commented on
the potential for it to be multi-use, so long as it's actually dealing
with the slightly separate needs. IOW I think it can be one file, but
it needs to allow for files that want excluding from rule checkers, but
not from style ones, and vice versa. Whether specific "comment" wording
would be suitable, or whether instead separate attributes would want
introducing is TBD.
Jan
|
