[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] ns16550: add support for polling mode when device tree is used





On 18/07/2023 15:13, Oleksii Kurochko wrote:
RISC-V doesn't support interrupts for the time being, so it would be nice to
have polling mode.

The patch assumes that polling mode will be used if there is no interrupt
property

As I asked in v1, please explain that this is allowed by the binding and provide a link for others to verify.

or the interrupt is equal to some unused UART interrupt number ( look
at the definition of NO_IRQ_POLL in ns16550.c ).

Nack. If you want to use polling mode and yet have an interrupts property then you should provide the information differently. This would either be via the command line or an extra property in the DT node.

If the latter, it would need to be standardized first.

Cheers,

--
Julien Grall



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.