[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86: fix early boot output
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Wed, 19 Jul 2023 10:17:10 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XxisrErvsXmxBmJIG4SlnuK6E7NZw1Zrn0X14k5RaV8=; b=BOG76Dq5CuIkdHLZUPu41rBY+9Zwgwq0Vyyz/lPMmLhwhfw0/8NNQMCdnxl6XGDInZcnZ1+NnCNiVEQpH5rGigvj8VqdSnVm947inNO2xB7TT3STVnMlkj3YdmcDbVo5EpE/GzIcpIYeqwd3eJ3xh0H6Hsj3ntj/QWAD3Wk/XOGbCfOgXicfnm7HKxyUEhGm5dskDMkDKgiO25nLcCTKnKGqYLGGgksqlPJfn8YykBPZMufM2KH3bZDARi0VwWxQigO0GbHCDlyhga80XzcUTzCeLS3DWgr8iS8a3FYX2zfYzkHqq4lchdSEENmLOcASHBbJfl8xN8C0UWyxuwDDHA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h9CHrj0bpEZyVc23QGLnoGZFAe+L3F/CYtlZjuAd0qIwmObT9hVq0XiFzEk7dWe7J/yj7tkPp1zkTWlr5nogniej7Jt4OH2NHWAkUhwDzG3Keq/TLIpoBw01hJY7HjS1yeHA2yQYjEnPxuP1Ecuiq+dYbQNllxV11YszhO1Oai2txSNDSbAWtKfVzI+1XCTzo4xnoQ4N0iVUSf6VUsJJQvJNiTz4y2CQOI9A4VVDgFy1hO4KnCoGGum9DBn/O9mhGWIlO1bVms++SAEuvAm4tpZ5VvfxyN+uvS3nqyhS4zn/OLwE0MgAKxXM4ucjeWBrU90MabiJAMjdoI90cU3QHA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Wed, 19 Jul 2023 08:17:52 +0000
- Ironport-data: A9a23:RsaZH6vxQC9nCeg5K4J1acbSvOfnVHBfMUV32f8akzHdYApBsoF/q tZmKW2FaK7eY2GjeYhyPo+xoUlXu8PTx9NnHVBv/no2FXsU+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4rKq4Vv0gnRkPaoQ5ACHxiFMZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwdgoufgy5mryN2Z3qUeZuloN7A5KwI9ZK0p1g5Wmx4fcOZ7nmG/+P3vkBmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osj/6xabI5efTTLSlRtlyfq W/cuXzwHzkRNcCFyCrD+XWp7gPKtXqiBt1LROHhp5aGhnXN+DYZBRcdBGK3huWSm0zmAINUc kMtr39GQa8asRbDosPGdx+yrWOAvxUcc8FNCOB84waIooLE7gDcCmUaQzppbN09qNRwVTEsz kWOnd7iGXpoqrL9YW2Z3qeZq3W1Iyd9EIMZTSoNTA9A+N+6pog21kjLVow7TPfzicDpEzbtx TzMtDI5m7gYkc8M0eO84EzDhDWv4JPOS2bZ+znqY45s1SshDKbNWmBiwQKAhRqcBO51lmW8g UU=
- Ironport-hdrordr: A9a23:BteHQKzX5KiATWI7LNUhKrPw2r1zdoMgy1knxilNoHxuH/BwWf rPoB17726TtN91YhsdcL+7V5VoLUmzyXcx2/hyAV7AZniAhILLFvAA0WKK+VSJdxEWtNQtsJ uIG5IUNDSaNykfsS+V2miF+9ZL+qj5zEir792usUuEm2tRGtBdBwQSMHfqLqVvLjM2fKbQjP Cnl7d6TzzLQwVuUu2LQkMrcsLkvNPxmJfvcXc9dmIaAFnnt0LS1FbieSLopCsjbw==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Jul 19, 2023 at 09:06:08AM +0100, Andrew Cooper wrote:
> On 19/07/2023 8:38 am, Jan Beulich wrote:
> > Loading the VGA base address involves sym_esi(), i.e. %esi still needs
> > to hold the relocation base address. Therefore the address of the
> > message to output cannot be "passed" in %esi. Put the message offset in
> > %ecx instead, adding it into %esi _after_ its last use as base address.
> >
> > Fixes: b28044226e1c ("x86: make Xen early boot code relocatable")
> > Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> When I was doing the label cleanup, I did wonder how this worked, given
> that it clobbered %esi. I guess this is the answer...
>
> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>
> Although it occurs to me that probably want to (optionally) use one of
> the IO-port/Hypercall protocols too to get these messages in PVH boot
> case too.
Using XEN_HVM_DEBUGCONS_IOPORT would be my preference, as it's the
same IO port that's used by QEMU as a debug console.
Roger.
|
