Re: [RFC PATCH 2/4] xen/arm64: bitops: justify uninitialized variable inside a macro

[Julien Grall <julien@xxxxxxx>]

Hi,

On 19/07/2023 09:54, Nicola Vetrini wrote:
> On 17/07/23 22:45, Julien Grall wrote:
> > On 17/07/2023 21:40, Julien Grall wrote:
> > > On 14/07/2023 12:49, Nicola Vetrini wrote:
> > > > The macro 'testop' expands to a function that declares the local
> > > > variable 'oldbit', which is written before being set, but is such a
> > > > way that is not amenable to automatic checking.
> > > >
> > > > Therefore, a deviation comment, is introduced to document this 
> > > > situation.
> > > > A similar reasoning applies to macro 'guest_testop'.
> > > Would you be able to check if the code below (only compile tested so 
> > > far) would silence Eclair?
> > Hmmm.. I think my e-mail client mangled the diff. Here an unmangled 
> > version if needed:
> > http://paste.debian.net/1286154/
> >
> > Cheers,
> I have a question: wouldn't this patch also imply an update of 
> xen/arch/arm/include/asm/guest_atomics.h ?
> This in particular is the bit of code that needs to be reworked to use 
> the newer *_timeout definition.
My patch is not changing the exported *_timeout. It is only changing the 
definition of int_##name which is not exported.
But I have realized that one chunk were missing. Here the new version:

https://paste.debian.net/1286311/

Cheers,

--
Julien Grall