[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 3/3] xen/riscv: introduce identity mapping
- To: Oleksii <oleksii.kurochko@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 19 Jul 2023 13:38:02 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YAu+K1yGs6EyfiupcFnDZvDzmMJj/ZtuJmcoKmLMP/s=; b=PvFVVlA8Hq4pojMSD1Y+jrG9oXpIu5KJlUNZUaTVpGeHQMMczPe7ZlHo8eNcFiYIFNFXZ7x6LuKy5n4XgMIEPqGvAcIjGvMYGmpCDV4W3ZJ4qofCVPnFb6VGE2s5l7df2otc7RQcAhIhjWRfIpe/xwCkQD5KQFbyVRg6fjA0IH96Ol6urXAkXWlFpHYTZtALjFfmES5Q8ZLDw2XzDYDP2Xq8HW5m3ZuHmsINUjc7HsC7LoMGW4uJ8YwQ1RGFyZZTL7LzNnI6i9XKOsuHcX0RvdE6+J4fuOPAdUB/qmS5SQ9QPI2qlWPlsxvNtzHASt8Yvv28k7hRwLzDhBxSNdWp7g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DG82uEcMRZc/LSokcWf8/F5vq1bJ5EGREiiLiwjJQp4ByVIITGHsnaCPRTwXy0o1dJRmNy5jmBbsvSr+EakuJdYVYZRPJPvAssdVznUsjJ7GxANxF0ptp0tX/dMUo16Zbxg0/T/euENcDPwu9gWUUvVCLE0WEvDXT5OZYmJsNUiXUE42RhxfFHRaL0b4l19XWdkCqJu5juyyAcpeAiwRoKX0lhaa/CbSd/0dBFzHn4wKe3S3Jl1mL+PmNm3Ue1Kdb7eZ/mBuNxEJ/aGu8uh8kNBXUO65yUI1Rfi1OuteB9d+uDJwF5GQ4M92DaD6So76rvP+N7kWfedhSLdOXn3WoA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 19 Jul 2023 11:38:42 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19.07.2023 12:39, Oleksii wrote:
> On Tue, 2023-07-18 at 17:03 +0200, Jan Beulich wrote:
>> On 17.07.2023 16:40, Oleksii Kurochko wrote:
>>> @@ -35,8 +41,10 @@ unsigned long __ro_after_init phys_offset;
>>> *
>>> * It might be needed one more page table in case when Xen load
>>> address
>>> * isn't 2 MB aligned.
>>> + *
>>> + * CONFIG_PAGING_LEVELS page tables are needed for identity
>>> mapping.
>>> */
>>> -#define PGTBL_INITIAL_COUNT ((CONFIG_PAGING_LEVELS - 1) + 1)
>>> +#define PGTBL_INITIAL_COUNT (CONFIG_PAGING_LEVELS * 2 + 1)
>>
>> Where did the "- 1" go?
> My fault. Should be:
> #define PGTBL_INITIAL_COUNT ((CONFIG_PAGING_LEVELS * 2 - 1) + 1)
Why? I'd have expected
#define PGTBL_INITIAL_COUNT ((CONFIG_PAGING_LEVELS - 1) * 2 + 1)
Jan
|
