[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/hvm: Allow hvm_copy_to_guest_*() to come from const sources


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 19 Jul 2023 14:34:31 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GebT5ibwqiK8B0jNzdjNV8syz8KD1POtQzM2wkK0Al0=; b=Z94Gw3y5TvF5bKNU1VQnj2+QRRVP48ndwUvndYqUbgA45vrXvEquDHJiY1/XcY5Y7LWIhZd6WqrgiS3F8ise2rSkwk/P0G6Y0DeR8C6jMLN+crkTe9Y4+oUn1/3jg7dzI+8g5xotIEZK7FcqtS0kbVLjJZnIe/JScqxxQ4w7jeQcm5MWQ1YcPaNiE7xB3hNiASUyl25PayvQR8JMJdW1WzbAt5opHjeT3pZ4wlJhgqKOOVnMygZ+qkkHFfd3HYjqcKfPJzNEEhnp7Vj44heaAiWc1QciHPAqKi/I6Pp4HDk86IMHdV2Rxp/TY72Lr4FRGEjCE+kiTU69KsxJcC7vVg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SiCu8d3QxuDCo3F8ae2mB6iAD8iEHUUcm80hjFCHW8RqgGKH/9YAdSraAW1CxD+IybJkPlZ/Eho/1pIrfYlauOHv8x/7IPse8wNr8vP4U6e9BWFre+fo6ue+hFY/jyiW0XLsyeR1GwRX9cyDA06pZqmol7i2g8nS7YqsFddHmYZR3qQBWjQici4Cl3wNjS3+GZ96wglpSOlgyTSgbi0ZqJfyoWFWPgrNZriXdEdygX0JCBM0ARO/ndVdGYjqiHpL3omWlJ//cWbCzYIh5kpGNF37Ah8a1PClwo8y0dHegJnjLwlbUUPplEm+uSV8Id4hDGmF6e0kQg7s/Zek8J+ydA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Wed, 19 Jul 2023 12:34:47 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 19.07.2023 14:24, Andrew Cooper wrote:
> The work to fix MISRA rule 7.4 (using mutable pointers to string literals)
> identifies that string literals do indeed get passed into
> hvm_copy_to_guest_linear() by way of the PVH dom0 command line.
> 
> This higlights that the copy_to_* helpers really ought to take a const
> source.  Update the function types to match, and cast away constness in the
> wrappers around __hvm_copy() where HVMCOPY_to_guest is used.
> 
> No functional change.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Well, yes, what do you do.

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.