[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [PATCH 0/7] Reducing visibility and cleanup of .cfg parsing symbols
These patches started as an effort to try to isolate the layers of the domain configuration file parsing. Theory being it might be possible to replace the lowest layer with something better. I noticed libxlutil.h isn't very consistent. Some functions were naming the configuration argument "cfg" and some were leaving it unnamed. There were also some very short names. Then inside tools/libs/util, far too much layer-specific detail was in the headers and didn't need to be. Turned out most things in libxlu_internal.h didn't even need to be in a header. Then some portions should have been in other headers since they didn't need to be so visible. There are a bunch of headers in tools/libs/util. Due to their number I need a guess as to their intended purpose. I've concluded "libxlu_internal.h" is meant to be a general utility header for anything used by multiple layers. I've concluded the *_i.h headers are meant to be isolated to specific layers. Elliott Mitchell (7): tools/utils: cleanup formatting of libxlutil.h tools/utils: rename "n" arguments to "key" tools/utils: move XLU_Operation to libxlu_cfg_i.h.h tools/utils: introduce xlu_cfg_printf() function tools/utils: move XLU_ConfigSetting & xlu__cfg_set_free() to libxl_cfg.c tools/utils: remove libxlu_cfg_i.h from libxlu_disk.c tools/utils: move remaining lower-layer data from libxlu_internal.h tools/include/libxlutil.h | 31 +++++++++----------- tools/libs/util/libxlu_cfg.c | 37 ++++++++++++++++++++++-- tools/libs/util/libxlu_cfg_i.h | 37 +++++++++++++++++++++++- tools/libs/util/libxlu_disk.c | 15 ++++------ tools/libs/util/libxlu_internal.h | 47 ++----------------------------- tools/libs/util/libxlu_pci.c | 3 +- tools/libs/util/libxlu_vif.c | 4 +-- 7 files changed, 94 insertions(+), 80 deletions(-) -- 2.30.2
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |