Re: [XEN PATCH] x86: change parameter name of hvm_monitor_msr() declaration

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Tue, 18 Jul 2023, Federico Serafini wrote:
> Change the parameter name of hvm_monitor_msr() declaration from
> 'value' to 'new_value' to match the corresponding defintion.
> This fixes a violation of MISRA C:2012 Rule 8.3 ("All declarations of
> an object or function shall use the same names and type qualifiers").
> 
> Signed-off-by: Federico Serafini <federico.serafini@xxxxxxxxxxx>

Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>


> ---
>  xen/arch/x86/include/asm/hvm/monitor.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/arch/x86/include/asm/hvm/monitor.h 
> b/xen/arch/x86/include/asm/hvm/monitor.h
> index 5276b0af08..02021be47b 100644
> --- a/xen/arch/x86/include/asm/hvm/monitor.h
> +++ b/xen/arch/x86/include/asm/hvm/monitor.h
> @@ -25,7 +25,7 @@ bool hvm_monitor_cr(unsigned int index, unsigned long value,
>                      unsigned long old);
>  #define hvm_monitor_crX(cr, new, old) \
>                          hvm_monitor_cr(VM_EVENT_X86_##cr, new, old)
> -bool hvm_monitor_msr(unsigned int msr, uint64_t value, uint64_t old_value);
> +bool hvm_monitor_msr(unsigned int msr, uint64_t new_value, uint64_t 
> old_value);
>  void hvm_monitor_descriptor_access(uint64_t exit_info,
>                                     uint64_t vmx_exit_qualification,
>                                     uint8_t descriptor, bool is_write);
> -- 
> 2.34.1
>