[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH] x86/mtrr: address violations of MISRA C:2012 Rule 8.3 on parameter types
- To: Federico Serafini <federico.serafini@xxxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Thu, 20 Jul 2023 14:15:58 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WWIpMevzRhdKGXA0bxDmTSuWYuOYOKxMh61YzzmJ6dk=; b=APQ5NApeiwGPyB2nCPZxsUim23Y193n68DN1VNvXzfkEL0GEICdCeArmk2g2ujLtd+iz/7F1j/3yo9vDUjUYDzLXG9efPZiHFnp7IR07XoLh6kKA0kAgtY/+ilBwTwznYJ+0yD0lIqVr6vTWKkBpr8Y/KBhRp+x/Bo68V7iL5sMbVY7rDiq2o5DSCsmnaWlZ/U0DqFXaI8nRIY55GvTNiaKtcLCTGp9TFooyXKWKqfcEwbkjWnrAJTBRvU7PLYgFDI7/lNkq+jY4pM0teB32IbjT0R/J+qv2EyyW3FcQipiHo2C4c9hx3x6AiWF53AzxI/lWf6zLnqGjUKyXRpHLuA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C3qaGng52C5ceGYznhSHRt/77CV/Yp9cwAvXVybrDyXzgD+WRcBfy22TMBpAOSsQbUOtuWefWDUw5ZTZNyYUHVa3nijRNu2ZHs2SlsM7VMSzZ17Fv7TzMG8BhZMW0I4Nr3blCiIDH97dfS6aVtH3ltVlgQhUSG9py+MuszZHZBq1e8gP6qTrAmcpGQMLk53qDaQebhNiI0xKD0Hb+C8535OursC1mGQ9oqTU8sKKKoElroSnq+Ym5TVqolBKiLv3b8dXqyg2aqiKSj3Rn2zAGtHzUysr/PNIjo3x7ufdGif7YqfGbYZTMzZsK9JYeGSP0vvx5KGsaIUY6n+MF+IoXg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, consulting@xxxxxxxxxxx, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Xenia Ragiadakou <xenia.ragiadakou@xxxxxxx>, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
- Delivery-date: Thu, 20 Jul 2023 12:16:47 +0000
- Ironport-data: A9a23:/0WsO6mCWO4BFhMmCNFAFSTo5gw6J0RdPkR7XQ2eYbSJt1+Wr1Gzt xIZW2vXbvmCZ2GhftolOty/8UsF68ODyIUyT1c5+ylmHiMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE0p5K2aVA8w5ARkPqgU5geGzhH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 dwYLx5UTzPcvNr1xKOKTehd3cQfdsa+aevzulk4pd3YJdAPZMmbBo/suppf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVk1Q3ieC0WDbWUoXiqcF9hEGXq 3iA523kKhobKMae2XyO9XfEaurnxHqkAtNLTeTinhJsqHiv/25IMT0rbnqioMP+hkSVAvddd UNBr0LCqoB3riRHVOLVURC0rWSFtRlaQNdKGuM77gClwLfb+AufCS4PSTspQMwrsoo6SCIn0 neNnsj1Hnp/vbuNU3Wf+7yI6zSoNkA9JmgEfjIAUQoD7PHpvY4ogxTACN1kFcadjNf4BDXxy DCitzUlivMYistj/7q/1UDKhXSrvJehZhUu+gzdU2ah7wV4TI2ofYql7R7c9/koBIOYRVmIu D4DgdqT6MgHCJ3LnyuIKM0dEbeo7rCfOTLdiFJmHJ483z2o9zioeoU4yDhvLUEvMdsBcCWvY EbXtQ5LzJZWMD2haqofXm6qI8EjzKylH9K6UPnRN4JKesIoLFbB+zxyb0mN2WyriFIrjaw0J Zacd4CrEGoeDqNkijGxQo/xzIMW+8z3/kuLLbiT8vht+efADJJJYd/p6GezU90=
- Ironport-hdrordr: A9a23:q2yhHqpgw7fqK298KLlRG+saV5oDeYIsimQD101hICF9WcaT/v re58jzGyWE8Qr5OUtQ4exoXZPrfZqyz+8R3WB8B8bBYOCighrKEGgA1+rfKl/baknDH4dmvM 8KT0E9Mr3N5DNB/KHHCWeDYrAdKRq8nJxAR92y856gd25XgmhbgTtENg==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Jul 20, 2023 at 12:48:36PM +0200, Federico Serafini wrote:
> Change parameter types of function declarations to be consistent with
> the ones used in the corresponding definitions,
> thus addressing violations of MISRA C:2012 Rule 8.3 ("All declarations
> of an object or function shall use the same names and type qualifiers").
>
> No functional changes.
>
> Signed-off-by: Federico Serafini <federico.serafini@xxxxxxxxxxx>
> ---
> xen/arch/x86/include/asm/mtrr.h | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/xen/arch/x86/include/asm/mtrr.h b/xen/arch/x86/include/asm/mtrr.h
> index e4f6ca6048..5d57a596ea 100644
> --- a/xen/arch/x86/include/asm/mtrr.h
> +++ b/xen/arch/x86/include/asm/mtrr.h
> @@ -59,9 +59,10 @@ extern int mtrr_del_page(int reg, unsigned long base,
> unsigned long size);
> extern int mtrr_get_type(const struct mtrr_state *m, paddr_t pa,
> unsigned int order);
> extern void mtrr_centaur_report_mcr(int mcr, u32 lo, u32 hi);
> -extern u32 get_pat_flags(struct vcpu *v, u32 gl1e_flags, paddr_t gpaddr,
> - paddr_t spaddr, uint8_t gmtrr_mtype);
> -extern unsigned char pat_type_2_pte_flags(unsigned char pat_type);
> +extern uint32_t get_pat_flags(struct vcpu *v, uint32_t gl1e_flags,
> + paddr_t gpaddr, paddr_t spaddr,
> +
> uint8_t gmtrr_mtype);
Wrong usage of hard tabs.
Thanks, Roger.
|
