[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 3/4] xen/ppc: Implement early serial printk on pseries
- To: Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 21 Jul 2023 07:57:47 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7RKzNKUcgt5uxUNRKvjbWiQ3/p8Fq2It+DQgky1Xi4k=; b=f9t7dQj8e0OoThm3TWbFLK3wH9REUe+Q5ke1wOvjOMsjVIfujC7+XPIVFIW6nEChSM17BO9MExd3He3nr2yPB2OLKMdumqI8fYRpTcD1U9NNPAgiAeRiuodqqqMBzsaF+ARjDG4wVuwEx4Y7Yyio3qN8sfA9zWyFXxgh+lcqpClPzjlAckNgcuLpzNEC0KBJb+oLpPso1+lKR96/0fLgEgkGVbbh/33bdWgCgVfcIEiLlZpdDNkcKslPpdSkmcXSZEaMzy3whGMFgZiBZ768GmI5WX01a5Xd24IMnQ6HsjAs6ZeL7yDdlklU9aBObZxjcdjMygUOiH/C1oJ4O1IRzQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dbVlv1r75S+DpECCnV/Ou0jNmTPE1fhUGSx9FaBzZ3BT2bhPkDyWEiw/21RjW4L6r9oWTos9jzdoRsmMhl+J73kbNU+LOCdQLEyDK0muyV6zN8h8dP4gDI0cOmUHdDuhT/Mcnu8TSzw+g5ky9F2VTY1bPBPnyA4KsKLdEVCacrtCXc2LrYEXbXGHd7Fd5lRRMGFkWDzXDhUhT0TcHpCKSctuaa8mW9A/X6sUrI4UoQ0+x87p+OUUG1hYcYeP0jjWnDu6C8Hozr6+u3EcpeYlLgTMXtQckCrXFObUWGuO5hAviu1L0hERlfw9csdKaUHDA6exvnn7wRSjnwRO31NGWw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Timothy Pearson <tpearson@xxxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 21 Jul 2023 05:58:00 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 20.07.2023 23:01, Shawn Anastasio wrote:
> On 7/19/23 9:05 AM, Jan Beulich wrote:
>> Before you/we grow more assembly code, may I re-raise a request regarding
>> readability: I think it would be nice if operands started at a fixed column,
>> unless the insn mnemonic is unusually long. Where exactly to draw the line
>> is up to each archtecture; on x86 we use 8 positions from the start of the
>> mnemonic.
>
> There is quite a large variance in mnemonic length on ppc -- many common
> mnemonics only use 2 characters (e.g. ld, mr) while other common ones
> use 6+ (e.g. rldicr, the mtspr family, etc.). Enforcing a column size
> that's too short would make the longer mnemonics look misaligned and out
> of place, but using a longer column length (like 8) that can accommodate
> most common mnemonics adds too much space between short mnemonics and
> their arguments.
Common length is 3 on x86, and as said we use 8.
> That said if you still feel strongly about this then I am not strongly
> opposed to adding an 8-space column alignment.
I certainly think it helps readability a lot. 8 also matches the common
use (fair parts of gas'es testsuite, Linux) of hard tabs.
Jan
|
