[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v8 11/13] vpci: add initial support for virtual PCI bus topology


  • To: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Fri, 21 Jul 2023 16:00:39 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EGCR4WQjahRGD85HAR+HBHPkFJZjYjOYKGK+49iIN4k=; b=ZBLCUHo9ROJ1BPnPFGHByYdb5QF+MHbt50HtwvrBphaT3Lxs7z3TKuNiM9t/43ssj/fgb8CZc5iiq+cd54E0Orvgc7Vvzew2M5abH9YhEEZ5QESIlzjt9kVpA0bnJMURo6Kt0ADkKENFFXSWMEmKdQblFGbptgtiEv9+5mvPvIHKzmgm1ER2IZvPsNcNkXfggSYuQSIR530B9xREuS4Ngd0zns2PKyxed04c4zaP+r+Vyq+OkcGQg/cxkY/+mHORvOMelL8JbKMLvAx2OjQtR8JyV/KeIlXcNVffX/M7cZKoORLrF75sUASp2cyzy+JdAqPB0t8oAnZRJWbFinVolQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QrHxPp5EhwhCMjvzV3aVw+MtfStgColXoERm4KfgTmNFgsxIjzk5ddu+pGbACWHVFLHvuqKQdoTxmu6nJ+xvfRTz+xu7jktRgoZ0hKfcxiYjafecMsUZpE+DXeHJxeh2BAqS6I+scYCyRvByCLujJMM+c6YeVuca7xgEW3KY1h0MMHndx0MlA+vGy4kB+3UUqyjrlayPHDzMqxGRlVGiBeXUwKshCwrp/kaBe1WL9zjZ3cJdVRp/PwNGBhLjeNLsFL/E4yug412atxIKN7YKgh1JJgtU7l7rdfTt9p0B77wQEhgOjmKMI1pwp4EXpAa6aAKjw7R0pwULJfLXA3zc0g==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
  • Delivery-date: Fri, 21 Jul 2023 14:01:06 +0000
  • Ironport-data: A9a23:P6qP/a8Cr/gZn9sPIinwDrUDR3+TJUtcMsCJ2f8bNWPcYEJGY0x3z DdOCG3SPPyOa2r8edx+atm09hlVv8KEnIVjTgdt/Hw8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ird7ks21BjOkGlA5AdmOqoS5Aa2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklkz /A7dgAvLSuOhuu6kbm5ZOBAhp08eZyD0IM34hmMzBn/JNN/GdXvZvuP4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWDilUpidABM/KMEjCObd9SkUuC4 HrP4kzyAw0ANczZwj2Amp6prraWw3OrAN1LSNVU8NY2oH3Q+EsWUicmWGu0gKeCqWOwRs9Qf hl8Fi0G6PJaGFaQZuf6Wxq0sXuVpCk2UtBbE/A5wAyVw6+S6AGcbkAUQzgEZNE4ucseQT0xy kTPj97vHSZosrCeVTSa7Lj8hRS2NCsOJGkOfxgtSwcf/sLjq4E+iBHIZtt7GavzhdrwcQwc2 BiPpSk6wrkW08gC0vzj+Uid2mr14J/UUgQy+wPbGHq/6R90b5KkYIru7kXH6fFHL8CSSVzpU GU4pvVyJdsmVfml/BFhis1RdF11z55p6AHhvGM=
  • Ironport-hdrordr: A9a23:D9eWVat21eeLQXv86tN3IRLQ7skDUNV00zEX/kB9WHVpm5qj5r qTddAgpGbJYVEqKRcdcLG7Sc69qBbnn6KdjrNhXotKMDOHhILKFvAH0WKB+UyDJ8SkzJ8k6U 4IScEXY+EYZmIK6PoSjjPYL/8QhPGa7aayif7a3x5WPHpXgmJbgzuRyDz3LqS7fmZ77FMCeq ah2g==
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Thu, Jul 20, 2023 at 12:32:33AM +0000, Volodymyr Babchuk wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
> 
> Assign SBDF to the PCI devices being passed through with bus 0.
> The resulting topology is where PCIe devices reside on the bus 0 of the
> root complex itself (embedded endpoints).
> This implementation is limited to 32 devices which are allowed on
> a single PCI bus.

I do wonder how this will work with ioreqs, iow: shouldn't it be the
toolstack that selects the virtual slot of the PCI device (in the
guest bus).  Otherwise I see a hard time reconciling how ioreqs and
vPCI can work together if vPCI has it's own (private) view of the bus,
and thinks it has exclusive ownership of it.

It might be something to deal afterwards, but would likely need a TODO
tag in order to realize it needs to be improved.

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.