Re: [PATCH v2 2/2] tools/xenstore: fix get_spec_node()

[Julien Grall <julien@xxxxxxx>]

Hi Juergen,

On 22/07/2023 09:16, Juergen Gross wrote:
> In case get_spec_node() is being called for a special node starting
> with '@' it won't set *canonical_name. This can result in a crash of
> xenstored due to dereferencing the uninitialized name in
> fire_watches().
>
> This is no security issue as it requires either a privileged caller or
> ownership of the special node in question by an unprivileged caller
> (which is questionable, as this would make the owner privileged in some
> way).
>
> Fixes: d6bb63924fc2 ("tools/xenstore: introduce dummy nodes for special watch 
> paths")
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>

Cheers,

--
Julien Grall