[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH] xen/spinlock: mechanically rename parameter name 'debug'
- To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 24 Jul 2023 10:14:35 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GuQbyCz36jECV6NW3wW27Dl7yC8SZKX91NwYgwxCHlc=; b=ahJnjWSghrwOcovt65x4aNCechLA4ZqSSeuAcwv2xIL1l1OHE8rjo+OkjMPakxCkK5AXpO1YSgESx6vMF4xMFRcWwFODM9p86NUUwnjFgYOwiyNPxP0oN2afQ0pIiQYjBxC2mwNI4tsbgiBdZgqKwr7ZWa5FaH6nAeCaOCW5Vbp1+SEx1PbhHDGj/1TR4/LaTNnWwz6xq/H0FPfq8dDHfUbZn3abVJJNNXTJv8xftzp347jCBkMH2f/im1or4GckmEIucqlzMDiD04uTH+o0LWUb0uWiRUQ9a7kxT2O8tYUTsFD0tYMcDehJBF+b7UqNUKfIY2Pg49790/OL0Zai+Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VeVriaNBd6dBHlxhWtNPyzUrQSnx+IhRQNMbItS3Y+S2cu1OAocnXdTgW8lNJ3yPs/IluI2T8kFbmW81snQSQkfbm6SgkgVA3LuIT3MYbcqpOkLLtChWqks1a5agd9miEu2LDTq52UMFJL8pMS4/drezaO0K5sNBw+ue6XXkRgeJckHoa+nab+iVk020oYhD4rDpyiSjImVVaAGiYGgGCIZVmnJ8rW80l7TrvCmKt3sSfNcV+NLx0M1sxbFSReKUh/FzZ2ICxDLCUb5q3SEvyOPxa8MxOKh4bCttXoi125yyKpCUxbIXReIAdAdjkoN8R+M3dVRiGtvONSEafTURyg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: sstabellini@xxxxxxxxxx, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 24 Jul 2023 08:14:49 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 21.07.2023 17:29, Nicola Vetrini wrote:
> --- a/xen/common/spinlock.c
> +++ b/xen/common/spinlock.c
> @@ -78,7 +78,7 @@ static int __init cf_check lockdebug_init(void)
> }
> presmp_initcall(lockdebug_init);
>
> -void check_lock(union lock_debug *debug, bool try)
> +void check_lock(union lock_debug *dbg, bool try)
I consider it reasonably likely that something named "dbg" might also
appear, when we already have something with as generic a named as
"debug". How about naming these parameters "ld", "ldbg", "lkdbg", or
yet something along these lines, but (at least slightly) less generic?
Another alternative would be to rename debug() to entry_DB(), along
the lines of entry_CP(). Andrew, didn't you once propose renaming all
the exception entry points like this?
Jan
|
