[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v8 08/13] vpci/header: program p2m with guest BAR view


  • To: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 24 Jul 2023 12:30:29 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EZmkc2QkwNO94vPcC2/TsHIaCueBdwovQsBRyUUDMOU=; b=KSFArn7o+XckPTX/Mx8nx9BYVE4uwwYPrY3rKTmO2P+0YVAIOslmyBTNV9nGbHxYEeGEpMvJPMArgALcDe48HZJPdyHrRIm1uwy/iNr0TYHfy7IfoU3iN5t2HAvhzpJ9dRAPctiKiH3c9WyMGIuN8Os1Uk0LWNhIi+b/CyX8CCyn/pJod3NQLFh6eBIJPhYhI0dq63TBqQ8Xp9jI5ifi2RGcpg8L2ZZfgJF7IJGotzdCPFVukQcHckMzKufrjTmFecZjM1444LPfSVRxvsKXQMnHAvP58IEoFYZrYy4RMeMoxIzGZDnrc5HfqkmIKc3YDshaw/sT49yt58LCCn1LrA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QQootZuVpSWOq/5x+mK42PBG6+koVF6f7+SAkjzQdB8Hz9V3kLiYuCv6dld21UARGm/3ZhghxafIst7uRI5imQAyNYtvi9lQkRuUYxQ749C6qQ6Rt6ihmRw/aBlDeAQxg0iWPwP5D4EwduVrpaf+mfQi833YorQU9Iu5ZwCXrGz+eK+ZEUE8vZXw8SJ7kCEDfU/89wbeHDvRpaO54C0vrmRU9pT1GowlBUZwP2G9K8LtHAAbez7YsZDnQq+CBRJHJ4yppDSPaZs+wkfz+6LR3t/JzOf4kEASCGmnWqwjmTStGTTD8c9TpNhB46e6F3XoISZziRZIXcZjGMoL9Z4Gww==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
  • Delivery-date: Mon, 24 Jul 2023 10:30:39 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 21.07.2023 15:05, Roger Pau Monné wrote:
> On Thu, Jul 20, 2023 at 12:32:33AM +0000, Volodymyr Babchuk wrote:
>> @@ -62,8 +76,8 @@ static int cf_check map_range(
>>          if ( rc < 0 )
>>          {
>>              printk(XENLOG_G_WARNING
>> -                   "Failed to identity %smap [%lx, %lx] for d%d: %d\n",
>> -                   map->map ? "" : "un", s, e, map->d->domain_id, rc);
>> +                   "Failed to %smap [%lx, %lx] for %pd: %d\n",
>> +                   map->map ? "" : "un", s, e, map->d, rc);
> 
> I would also print the gfn -> mfn values if it's no longer an identity
> map.

And also the actual range - it's not [s,e] anymore.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.