Re: [PATCH] xen/dt: Rework the prototype of dt_property_read_string() to help Eclair

[Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>]

On 24/07/23 12:24, Julien Grall wrote:
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> Eclair vXXX is unable to prove the parameter out_string will only be
> used the return of dt_property_read_string() is 0. So it will consider
> that MISRA C:2012 Rule 9.1 was violated.
This is not correct: ECLAIR cannot prove that the rule is not violated, 
and hence emits a caution, because the analysis is sound.
> Rework the prototype so the string is returned and use ERR_PTR() to
> embed the error code.
>
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
>
> ---
>
> The XXX should be replaced with the version of Eclair. Nicola, can you
> provide it?
I don't see as valuable mentioning ECLAIR at all, but rather explain 
what the change is about (encoding the error value as a return value and 
removing the **out_value parameter).
Regards,

--
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)