[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 0/4] Early serial on Power
- To: Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 24 Jul 2023 15:07:55 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Gv9cDQKBaLCNl+zKIQICHTqpJqJNTHABuJriI3EDKmY=; b=So7tYg6FyYb62/7/zcHp8rWYa99se4r3Bdc0GPDaGi7PQ9kPXclUJdcEnV5xXf3ZQ1K0lv3U/tVATsZHNmuur+1e0Su5KN9BuPtjHw5t2lZpQfWLlwP2sUm/dxzWA9H41UEGM11xgOvtVzAnZpE31WvsWwF7XMhMnBDvvaDXahIu57r+R9Ugd0+WZ9ngzDqv7z2z3MG7ebNOW7ukqv7YgjbqWYikhslG8C90YjIG/AvejxYE3gL5QdgqVXSPDdF83d3jn3fGfj2mOCgeWed/odI9nGI2p30DHhwB++Bt5lrlqKP6GolRyspKPR0asFiqsaTRZ5e4TfamwVJungcomA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kziCq6r4qQZN8YVOJGl7Wun0n1cKIBwv/oW8mN9tQ9eD/8kgCRQgTeKT4d9WLqmf4krAbRAeKOTGoBMO+1YShYSy6iqpWkKMOs6mulGYuj9ZMjZGHUBLql8i62kPxdsUV+gUou9tWVNPuU2XVwh+G7wdivNDsOct2TNGDl60aS2NQnnAKcUtcoV591qRGICkKdFNdUPaj+84JQwLW1Q1/Jz9dT0Kmtv40SHtRY6wfpA6bHlV9IBSEXYqmn2Yg3loJ4NeJulciwHpubQvkqwvcJQ/LNZQCrAID2CJoFSA0bjZqJhEjR3j6lvcqk6lobkUPKcuFdADFiRm7khck0Mw1w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Timothy Pearson <tpearson@xxxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 24 Jul 2023 13:08:03 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 21.07.2023 19:02, Shawn Anastasio wrote:
> Changes in v5:
> - (xen/macros.h) Add signoff
> - (xen/macros.h) Fix up comment formatting and macro parameter names
> - (*.S) Use 8-space column alignment for assembly
> - (of-call.S) Add missing space after comma
> - (asm-offsets.c) Fix DEFINE() macro formatting
> - (asm-offsets.c) Replace _Static_assert with BUILD_BUG_ON
One more general remark / request: Having change logs in cover letters
is certainly okay and better than none at all, but for review purposes
it is far more useful when provided in the individual patches. Not the
least because, as you will likely understand, the larger the series, the
harder it is to associate each of the remarks here with individual
patches.
Jan
|
