[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] xen/arm32: head: Widen the use of the temporary mapping


  • To: Julien Grall <julien@xxxxxxx>
  • From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
  • Date: Mon, 24 Jul 2023 17:15:30 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gWMj0fj3nc1fwJfKbqN1FEPborB7MLbH1vij1Yr698k=; b=ISAPTciBGzmfIhP71/EdO4HASYRFn5OZgKo5qjb6Y8lfrYpDpIsK9K4vreeYTo6HbZ3Ux7YFOs8WJ9vi7objZAAOcclPeE7sWw0dfFWSDl+ggpEwJglo8/V2Njp0lz20PKAq4IojyVKy6QpmtndP8qmv6hb+vGpgJTWjcOr3NkzBKCrcLcE2WwhxLc8YU6HsRXGwoNSlVT7GZ3MAxU2FdPvc+RsyslhVJ1m+8Itq4vaBd4PHUv2QKl0zoHBjg2fK+4azxSHMwRsY8wiiw415SHJZAuzj0CsucptRETfEFFK+KPkU2fAnsUfMt8LPktXWkBHxrZKdSCLdgbAkUV2nIA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=brbwSmU1JZHABirExMDqe0Z51rUXHjH0eQd3uIchd3Nu6fGKYTy5E0gk6MFf7+WaDUnRlvZEh70QEN09IwSes12y0OiWPo+GZE0TpfFKSB8/r4HNX4ANGZOZiYBOhDjLelAYAb+aOLLMUDBex8kGo/wiIGi6j4GoP3OoavE1E7lDWshssNyYJtU/QFOoTx413wkAJ7/glxHSu48i+fxscbLPxiW7RKnhNZpLm6R9761/HbOwLlurkZp74OVQhKpEhPkoQ6aLaJuFwsHR0U9vtnU/beC1CKJN3sqWNZlWOu45FPhCirg/3aIP1Q8hhBKoxkT8w8Hq9kNQOIMOpCZrOw==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "michal.orzel@xxxxxxx" <michal.orzel@xxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Mon, 24 Jul 2023 17:16:08 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHZvhfALUYUxcU0dEyDyil7nxQeXq/JKKkA
  • Thread-topic: [PATCH v2] xen/arm32: head: Widen the use of the temporary mapping


> On 24 Jul 2023, at 11:14, Julien Grall <julien@xxxxxxx> wrote:
> 
> From: Julien Grall <jgrall@xxxxxxxxxx>
> 
> At the moment, the temporary mapping is only used when the virtual
> runtime region of Xen is clashing with the physical region.
> 
> In follow-up patches, we will rework how secondary CPU bring-up works
> and it will be convenient to use the fixmap area for accessing
> the root page-table (it is per-cpu).
> 
> Rework the code to use temporary mapping when the Xen physical address
> is not overlapping with the temporary mapping.
> 
> This also has the advantage to simplify the logic to identity map
> Xen.
> 
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>

Hi Julien,

Seems good to me, I’ve also tested on qemu and FVP, creating/destroying guests 
and no issues so far.

Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Tested-by: Luca Fancellu <luca.fancellu@xxxxxxx>



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.