[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH] xen/dt: Rework the prototype of dt_property_read_string() to help Eclair
- To: Julien Grall <julien@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Tue, 25 Jul 2023 02:58:14 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HDaxQidPXi153G5dSHXyTPT6bcFllfwouMfRau4SKEM=; b=Eui7rlc4QzS6Y5rIMZ+xkuUaC2Vg6I6vHjrLc4q0Wo0SqNDZ48QyNLVwFdDN6eUpq/eWgryIAulOcq0qDi0bTLRtD5+Qa2CFx7JeeViHmUiqnNC9TBV88e4zBc0IOdABdNNj4RI3pT+MTEUJL4HQ7yZZuP78Togmqi20vfHbnr9tifc/RokIcMu+TXqr+UNtfQ5SRSPG6MviNuJS/GB5fnEgaGG3IdFE7qoK4OWVaII0LABuEExoZZBwBME9ZtinCg3+/G4tBO1QSrgrj2L2Bmqv96k1jpGF1W/0qtubGVOhAvzlw7vYLPM8i+D+AKtIlEO4qQ3ZldkLneljugR15A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F1IVtNqy1YEtqFEgPN8ge18GXe/KDjP7Xx3PZiTsDQ9J+mSLdJb6sv+rH8ZUI7yOQ1u3m2cHUEHnZPSbEHADjqxomsALzVfM+U4etKYM4FFDRsxRuIaMkiksjbq9q6B3Y1/qVZVJDNor99yzGsjWIyYAuwZkmZSXv6Kbf4PYmpYo/XKAtj+fiD+eYGpaUcA0C78s8OdnBchOkWHa2FNtFYGgbAFq74Is4eerNdWFsgkVGYjwjx4ImghhTRmpTyPHlFAWQrF3Wb0PUnPaRqSziFcM4yhURqFRmaCC9cy/PUfLuF3vOzOZPfMUdQN2r8mrOKWFvcX41zwJBB1XUNt/XA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "nicola.vetrini@xxxxxxxxxxx" <nicola.vetrini@xxxxxxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 25 Jul 2023 02:59:04 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHZvhkoHM9BIJ2JWEmZ3643dNrJDa/JsTlQ
- Thread-topic: [PATCH] xen/dt: Rework the prototype of dt_property_read_string() to help Eclair
Hi Julien,
> -----Original Message-----
> Subject: [PATCH] xen/dt: Rework the prototype of dt_property_read_string()
> to help Eclair
>
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> Eclair vXXX is unable to prove the parameter out_string will only be
> used the return of dt_property_read_string() is 0. So it will consider
> that MISRA C:2012 Rule 9.1 was violated.
>
> Rework the prototype so the string is returned and use ERR_PTR() to
> embed the error code.
>
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
> ---
> The XXX should be replaced with the version of Eclair. Nicola, can you
> provide it?
I am seeing some ongoing discussions about the commit message, but
the code itself looks good to me, and I also tested this patch to make
sure things are good, so:
Reviewed-by: Henry Wang <Henry.Wang@xxxxxxx>
Tested-by: Henry Wang <Henry.Wang@xxxxxxx>
Kind regards,
Henry
|
