[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 1/3] x86/microcode: Ignore microcode loading interface for revision = -1
- To: Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 25 Jul 2023 08:43:10 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IqWXcYfpK4ztMAnhZGAzcZh3J5RSTOKhD6SWS3tr2Fg=; b=hsfrEg0RTQxnorgBTl3olDY1jiDDu36/uKjV1XNs/+4ElhBdKx7d/yUc7IjKkZB2gB6BfVYU20yOSzgstes5uP42BBcX/flekDLztZKbrCJgwtVMQyYyhB5fOotGviqEJT2nqGdR4IgFcQRkle0Hiosy8cDP0uaUuDlhdHuuOxxPFa3nJm8wTJBpg0xaPfoAkAmmbRQd2pBX0JvZiDt1X+zGmD8h2dacfR0GAVkj9THYALkiCZxdZWnTj390WmQTyVowlRb/WXZqM9AYEPwfZeUb4KcaMCq9GOhUbY0a27XSj7nO8yZ6FJ5GYNBbV/7o7glNYaBEapZsZPpF4/4uFA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mat5TGBb5kQinOncVWKIudZNpL+TycH+/i/PIkWw3joISboM29W9Hqw2tEKbMbEsNuwJxzf4+ic/39GEV1rS11cfMsaTiOSmnl5N8sjbPhZ41PG67rtv/d+/cZf5Ich86xnlm8h/iXCgrnVigH7k6xUXo6iv2MRNmx9EzY2iOH00sKT8mVcuY1YMyTQRDWN32sDY1PomN2A9h20lZvY4DyrJgAtcH0J0DlgpRwBxLNvWxYQS8paOnKr1Y7gW0S0xo6GyqQ/iW04aCgWH9naspcgEesX6WZsc6WAERnOHn/e+OmxYWd5JthBdsOMgYt2K3O0nA7DyeGgVKgg9RkP4fQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 25 Jul 2023 06:43:19 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 25.07.2023 08:40, Jan Beulich wrote:
> On 24.07.2023 18:52, Alejandro Vallejo wrote:
>> --- a/xen/arch/x86/cpu/microcode/core.c
>> +++ b/xen/arch/x86/cpu/microcode/core.c
>> @@ -867,10 +867,23 @@ int __init early_microcode_init(unsigned long
>> *module_map,
>> return -ENODEV;
>> }
>>
>> - microcode_grab_module(module_map, mbi);
>> -
>> ucode_ops.collect_cpu_info();
>>
>> + /*
>> + * Some hypervisors deliberately report a microcode revision of -1 to
>> + * mean that they will not accept microcode updates. We take the hint
>> + * and ignore the microcode interface in that case.
>> + */
>> + if ( this_cpu(cpu_sig).rev == ~0 )
>> + {
>> + printk(XENLOG_INFO "Microcode loading disabled due to: %s",
>
> While we have tentatively agreed to adjust what _will_ be emitted by
> default (subject to suitable justification in that change's
> description), such a patch is yet to be sent. As it stands this message
> will be invisible by default.
>
>> + "HW toggle");
>
> With the comment talking about hypervisors, what is this string supposed
> to tell an observer of the message in a log file?
Looking at patch 3 I get the impression that you put here the wrong of the
two messages there.
Jan
|
