[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v2] automation: add ECLAIR pipeline


  • To: Simone Ballarin <simone.ballarin@xxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 25 Jul 2023 09:01:28 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/GmQPjoG/bIz6yjmRzHLmM//DVTJdsU9m6I2Dabl8Gk=; b=I0KcRwwt3+Lq5lnBCVEgnIfW7gjLNL4wyyRCkKvPFuPr8hps3shTvcxcOp9tylsWGQ3jh2QrkWFxOiL7+7yz8aiQgfT6u5T+62xtDmn9R+A5XAEWm0uFtXJQwbC2YUoKJIFz8nT7umqmRSk+0TGcVylHYByd4HuqTp1FkDs9Wrz8ky7SlhAVEVkrtVAOFl4YKbjWppEAwAEbjEuQuhlLPpmkl5VHGFuODXNI0hsr3PoOH9ZCLAYEsfaqwxfvcdsKwFAUT/eRS3dD1hB6emacqIU9CNms+7sXdrzm92UbAws5x3BftFHl8LQRXUAh6gDtdixPs0/og1MAXwtXEseHHw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Lw04vWB2m6oJh5BNYRcdx+PZvYzdV3U/QvAPXrti6b/J3GyzkN3nCyQ5qHR+V5bQRQ1U6jAGwF1GQAnInQ13uOpmLOxUYBwbVaMfxuiuU1vOYKyfrcNvkDwl5s/l+gmgXWjazTZ/QDToQUX06r5wtTgq/yhf7paaLtHIalNGYP9f+ZF+HyPgTwrdyOG+3X1NvVOzUtoWUC/WUg8hjiXwoDnFmr8h3UvFnpbo0hsNmRonRQjhKepB5nFWNUY1ePQIRkNzytpphxBU/YZrMcnSgK6s/8iLjakmCycgAfQr77LeP1iCQ/hwnLCuXMnY7ieiSMJdjIegP6uDdtsi++HSLA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Doug Goldstein <cardoe@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Tue, 25 Jul 2023 07:02:15 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 24.07.2023 19:25, Simone Ballarin wrote:
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -305,6 +305,12 @@ F:       xen/include/xen/libfdt/
>  F:   xen/include/xen/device_tree.h
>  F:   xen/drivers/passthrough/device_tree.c
>  
> +ECLAIR
> +M: Simone Ballarin <simone.ballarin@xxxxxxxxxxx>
> +S: Supported
> +F: xen/automation/eclair_analysis/
> +F: xen/automation/scripts/eclair
> +
>  EFI
>  M:   Jan Beulich <jbeulich@xxxxxxxx>
>  S:   Supported

Please follow surrounding style (tab padding, not blank). It also
looks as if the xen/ prefixes in the names were wrong. Finally,
following Stefano's suggestion to split - decisions to make people
maintainers of certain pieces of the code are usually separate
from accepting any code changes / additions. Hence even if tiny,
this change may want splitting out and putting last. Content-
wise personally I think we want to start out with R:, not M:, but
this would need discussing among committers plus maintainers of
automation/.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.