[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v2] xen/spinlock: mechanically rename parameter name 'debug'
- To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 25 Jul 2023 16:54:44 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GFjE/0XmVuJbmKxK+1O3d8vmuyqjKCrcDoeceA9/uBY=; b=dtNUxpDcIj2dbjXa1GkdkyxzIRTNQDhy+w7tUwuaBWtWAK+vhvE7rEk8IJBL9hTOKqAH2qRBWYgYYfnAPy5tCkFFPwXj8BaOndKQ1Fzd5ZPHY31yfcV4MoPWDsiKrFhagMrOHXCeQl/qhTK/GOU8kO68bc+QNIFnZl48tnoK29ll7jZzEUj4Tk37wSGxsFARSa6To94b8S/njsWCCyV2dVGhIaTlp+SCFfxcnCRpnum50KIZ2e7GXo7c0ZdreA1Kq5q/cSWL4tAot+7r41c2vxCwj2HeU0jrOtSWU+wxaAQe6u2v7RI+m3ZvbhAs6ng3tuO7p4BDQ3cZyg5eiRTY5A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M+N4uUizyVKy/AyJ44iX7BjfRDvnmAvbwCCh9l9PIFwz3xIvSyYZKUOClOOPUJIMxDqLxRgZ/XqHacrYSu0/Djoy2c5cLm4qkBuhpZ3AF70IfUU21AfqekRTbh2Aoz3Lx6Ek2Q8uyqKHBEZv5M/ocv6bymbyHannEMNC0WRsfF2oIW5zRgRN1KAe2tpCjJyuVYnyxKtxU8h42ESDHIvZ9bTz6ltFpkCpjCw5S4/UgTJxrmgU09CWOOLlalp/joDOBpiouydIvCMGget0fSjko1LF/qJ/K+SNckh6eQANOm5vOA575A7Zn4b6i1zyAWy5wZBULEW9HxorEyDAkstomA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: sstabellini@xxxxxxxxxx, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 25 Jul 2023 14:55:18 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 25.07.2023 11:17, Nicola Vetrini wrote:
> Rule 5.3 has the following headline:
> "An identifier declared in an inner scope shall not hide an
> identifier declared in an outer scope"
>
> To avoid any confusion resulting from the parameter 'debug'
> hiding the homonymous function declared at
> 'xen/arch/x86/include/asm/processor.h:428'
> the rename of parameters s/debug/lkdbg/ is performed.
>
> Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
> ---
> Changes in v2:
> - s/dbg/lkdbg/
But only in some of the cases. E.g. ...
> -static void check_barrier(union lock_debug *debug)
> +static void check_barrier(union lock_debug *dbg)
... not here (there are a few more).
Jan
|