[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 1/2] tools/console: Add escape argument to configure escape character


  • To: Peter Hoyes <peter.hoyes@xxxxxxx>
  • From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Date: Tue, 25 Jul 2023 16:40:03 +0100
  • Authentication-results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, <bertrand.marquis@xxxxxxx>, <wei.chen@xxxxxxx>, <luca.fancellu@xxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Tue, 25 Jul 2023 15:40:28 +0000
  • Ironport-data: A9a23:Orpo76rJwLvfBVsE79u84HV9GIteBmLBZRIvgKrLsJaIsI4StFCzt garIBmOPKuINmbxe95/bIm28hwDvJLSz4RiS1Blqyg0Fy5GopuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKq04GpwUmAWP6gR5weBzSRNVfrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXADUoNkGg3siU/KiAG+pK2JgAMcbCDKpK7xmMzRmBZRonaZXKQqGM7t5ExjYgwMtJGJ4yZ eJAN2ApNk6ZJUQSZBFOUslWcOSA3xETdxVRrk6VoqwmpXDe1gVr3JDmMcbPe8zMTsJQ9qqdj jucpzyhXEFCbbRzzxKqrkidwfHqxBrCc70WKaDl8dN1pxq6kzl75Bo+CgLg/KjRZlSFc8pSN 0EOvCopvKUp3EWxS5/2WBjQiG6JuFsQVsRdF8U+6RqR0ezE7gCBHG8GQzVdLts8u6ceTzEwy kWAmd+vADV1qaCUUlqU7LLSpjS3UQAKIG5Ebi8JSyMM+dylq4Y25jrLU91qVqC8iNb4HTXt6 zmQqW41gLB7pdEP/7W2+xbAmT3EjpHRQxQ8/An/QmOv5QQ/b4mgD7FE8nCCs6wGdtzACADc4 j5dwZP2AP0y4Y+lkQnVEcZUNpOV/c3UMxuC3X1yELAR3mH4k5K8Rry88A2SNW8wbJdcI2CzO xKK0e9CzMQNZSX3NMebd6r0Up13lva4SLwJQ9iONrJzjo5NmBhrFc2ETWqZxCjTnUclisnT0 r/LIJ/3XR725UmKpQdaptvxMpdxnEjSPUuJGfjGI+2PiNJynkK9R7YfK0epZesk9q6Cqwi92 48BZpPQkU4DALKiOXW/HWsvwbYidyNT6Xfe8pI/SwJ+ClA+RDFJ5wH5nNvNhLCJb4wKz7yVr xlRq2dTyUblhG2vFOl5QikLVV8bZr4m9ShTFXV1bT6VN40LPd7HAFE3K8FmItHKNYVLkZZJc hXyU5zdWqsfEmqdplzwr/DV9eRfSfhivirWVwLNXdT1V8cIq9DhkjM8QjbSyQ==
  • Ironport-hdrordr: A9a23:JtnFVa77WrNq9eOIuAPXwAzXdLJyesId70hD6qkQc3Fom62j5q WTdZEgvyMc5wx/ZJhNo7690cq7MBHhHPxOgbX5VI3KNGXbUQOTR72KhrGSoAEIdReeygZcv5 0QCZSXCrfLfCVHZRCR2njFLz4iquP3j5xBnY3lvhNQpZkBUdAZ0+9+YDzrdXFedU19KrcSMo GT3cZDryrIQwVtUizqbkN1OdQqvrfw5evbXSI=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Wed, Jul 12, 2023 at 11:29:16AM +0100, Peter Hoyes wrote:
> From: Peter Hoyes <Peter.Hoyes@xxxxxxx>
> 
> Dom0 may be accessed via telnet, meaning the default escape character
> (which is the same as telnet's) cannot be directly used to exit the
> console. It would be helpful to make the escape character customizable
> in such use cases.
> 
> Add --escape argument to console tool for this purpose.
> 
> Add argument to getopt options, parse and validate the escape character
> and pass value to console_loop.
> 
> If --escape is not specified, it falls back to the existing behavior
> using DEFAULT_ESCAPE_SEQUENCE.
> 
> Signed-off-by: Peter Hoyes <Peter.Hoyes@xxxxxxx>

Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Thanks,

-- 
Anthony PERARD



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.