[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 3/6] libxl: introduce MSR data in libxl_cpuid_policy
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 25 Jul 2023 18:07:23 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HWt6rW5kl9y6UOoEZ/2TMh97gnV/HRaeV3GhylKQ9U4=; b=FpAJxSN+c061y6p83Hmf3LxG19LHUuh6OGawC2jpkaY7erg1G2UVMIuhUGF6MCcpTY7xAciKw5sLGWWvadxZk5jRJt+75rRpuY9aHP4OB6MEv+1LXLxvn57elTQZDWdkEtT2V6SAJnzJKkVyygYMaOI/yF6q9uouSlK0dBBulLmgdTKHTGBZ0AZzY7SqkksS58Hve+tXMwDQwFz79BexmHmY9aZ1Q5H3I+okwbAVLU/sqn9oe7e8mbKxvi1BmwPyLmAnH0qCe+RkcR3V+ge+RFF9IdQaR5aneGVPSTRLxx7t+3n/Bf+5NeITm73T1W28TVZcMLjA84sbT7ES6bBDyg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iheyAoISehwLSc/ZSxwn5jfio3chab3tTyJqU2dGDdzwEK1NaXzBTmX5OlbHukekj6Q8mERoXWSTNCEBddSXDRg046NCXpHpX7H4xtGiPaFB7bZRWftPw8VbYhrmt4W/bm6GoWII+zHCeqNj79QlI5k06IOeC9JwcZh2sp7s1RRR7kq0r56xxS6/ayiZ0N8xWp+uXQURIzLz9IZ04mehDqurnX3+52rjTvKlz/rBspsp04JBh8C/SLwHMfJCvFT1GDMZKrmzqAOU0IK2TLMU2eKDsvXZ6nsbVvrBNAQioMuYWpiyNSkm+v4mIa6eSyQRoAONH9C6WMdcJ0s3UzwRUQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
- Delivery-date: Tue, 25 Jul 2023 16:07:40 +0000
- Ironport-data: A9a23:KffMHqB7Kx1WrhVW/wziw5YqxClBgxIJ4kV8jS/XYbTApGh33zAFn DQcDTvQOvmMazP9Ktkkbozj80xQ6pfQyIVqQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbCRMsspvlDs15K6p4GxC4wRnDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIwpdouOUxPq bsiAW42ciKegdmPzL7rY7w57igjBJGD0II3nFhFlGucKMl8BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTL++xrswA/zyQouFTpGMDSddGQA91cg26Tp 37c/nS/CRYfXDCa4WPcrS713reUwksXXqpKT6Pi+t0toGeomGMvCCJLFgSy+sOA3xvWt9V3b hZ8FjAVhbg/8gmnQ8fwWzW8oWWYpVgMVtxICeo45QqRjK3O7G6xGWwsXjNHLts8u6ceRzMw0 USSt8j0HjEpu7qQIU9x7Z+RpDK2fC0Kd2kLYHZeSRNfu4Wz5oYukhjIU9BvVravicH4Ei3xx DbMqzUig7IUjogA0KDTEU37vg9Ab6PhFmYdjjg7lEr+hu+lTOZJv7CV1GU=
- Ironport-hdrordr: A9a23:khY9IqtnIF2MwFLJ0Aq8SXfG7skDXdV00zEX/kB9WHVpm62j5q WTdZEgv3LJYVkqNE3I9eruBED4ewKkyXcX2/hyAV7BZmnbUQKTRelfBO3ZrQEIcBeOldK1u5 0AT0FIMqyVMbErt63HCdGDYq0dKQO8gcaVbDrlvhBQpN1RGtldBtlCe3ymLnE=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Jul 25, 2023 at 03:44:29PM +0100, Anthony PERARD wrote:
> On Tue, Jul 25, 2023 at 03:05:55PM +0200, Roger Pau Monne wrote:
> > diff --git a/tools/libs/light/libxl_cpuid.c b/tools/libs/light/libxl_cpuid.c
> > index 3c8b2a72c0b8..dd97699bbde7 100644
> > --- a/tools/libs/light/libxl_cpuid.c
> > +++ b/tools/libs/light/libxl_cpuid.c
> > @@ -592,17 +641,32 @@ int libxl__cpuid_policy_list_parse_json(libxl__gc *gc,
> > {
> > int i, size;
> > struct xc_xend_cpuid *l;
> > + struct xc_msr *msr;
> > + const libxl__json_object *co;
> > flexarray_t *array;
> > + bool cpuid_only = false;
> > +
> > + if (libxl__json_object_is_array(o)) {
>
> I think a comment here would useful to point out that we are parsing the
> format from previous version of Xen.
>
> > + co = o;
> > + cpuid_only = true;
> > + goto parse_cpuid;
> > + }
>
> Otherwise, the patch looks good now:
> Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Thanks, will add and send just v5 for this patch, as a reply to v4.
Regards, Roger.
|
