[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [XEN PATCH v3] device_tree: address violations of MISRA C:2012 Rules 8.2 and 8.3
On Tue, 25 Jul 2023, Federico Serafini wrote: > Give a name to unnamed parameters thus addressing violations of > MISRA C:2012 Rule 8.2 ("Function types shall be in prototype form with > named parameters"). > Keep consistency between parameter names and types used in function > declarations and the ones used in the corresponding function > definitions, thus addressing violations of MISRA C:2012 Rule 8.3 > ("All declarations of an object or function shall use the same names > and type qualifiers"). > > No functional changes. > > Signed-off-by: Federico Serafini <federico.serafini@xxxxxxxxxxx> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx> > --- > Changes in v3: > - use parameter name 'dev' instead of 'device'. > --- > Changes in v2: > - improved consistency in parameter renaming. > --- > xen/common/device_tree.c | 16 ++++++++-------- > xen/include/xen/device_tree.h | 20 ++++++++++---------- > 2 files changed, 18 insertions(+), 18 deletions(-) > > diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c > index 0677193ab3..0522fdf976 100644 > --- a/xen/common/device_tree.c > +++ b/xen/common/device_tree.c > @@ -85,11 +85,11 @@ struct dt_bus > unsigned int (*get_flags)(const __be32 *addr); > }; > > -void dt_get_range(const __be32 **cell, const struct dt_device_node *np, > +void dt_get_range(const __be32 **cellp, const struct dt_device_node *np, > u64 *address, u64 *size) > { > - *address = dt_next_cell(dt_n_addr_cells(np), cell); > - *size = dt_next_cell(dt_n_size_cells(np), cell); > + *address = dt_next_cell(dt_n_addr_cells(np), cellp); > + *size = dt_next_cell(dt_n_size_cells(np), cellp); > } > > void dt_set_cell(__be32 **cellp, int size, u64 val) > @@ -993,9 +993,9 @@ int dt_device_get_paddr(const struct dt_device_node *dev, > unsigned int index, > } > > int dt_for_each_range(const struct dt_device_node *dev, > - int (*cb)(const struct dt_device_node *, > + int (*cb)(const struct dt_device_node *dev, > uint64_t addr, uint64_t length, > - void *), > + void *data), > void *data) > { > const struct dt_device_node *parent = NULL; > @@ -1197,9 +1197,9 @@ unsigned int dt_number_of_address(const struct > dt_device_node *dev) > } > > int dt_for_each_irq_map(const struct dt_device_node *dev, > - int (*cb)(const struct dt_device_node *, > - const struct dt_irq *, > - void *), > + int (*cb)(const struct dt_device_node *dev, > + const struct dt_irq *dt_irq, > + void *data), > void *data) > { > const struct dt_device_node *ipar, *tnode, *old = NULL; > diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h > index c2eada7489..1d79e23b28 100644 > --- a/xen/include/xen/device_tree.h > +++ b/xen/include/xen/device_tree.h > @@ -538,7 +538,7 @@ bool_t dt_machine_is_compatible(const char *compat); > * Returns a node pointer with refcount incremented, use > * of_node_put() on it when done. > */ > -struct dt_device_node *dt_find_node_by_name(struct dt_device_node *node, > +struct dt_device_node *dt_find_node_by_name(struct dt_device_node *from, > const char *name); > > /** > @@ -622,12 +622,12 @@ unsigned int dt_number_of_irq(const struct > dt_device_node *device); > > /** > * dt_number_of_address - Get the number of addresses for a device > - * @device: the device whose number of address is to be retrieved > + * @dev: the device whose number of address is to be retrieved > * > * Return the number of address for this device or 0 if there is no > * address or an error occurred. > */ > -unsigned int dt_number_of_address(const struct dt_device_node *device); > +unsigned int dt_number_of_address(const struct dt_device_node *dev); > > /** > * dt_device_get_irq - Resolve an interrupt for a device > @@ -639,7 +639,7 @@ unsigned int dt_number_of_address(const struct > dt_device_node *device); > * device-tree node. It's the high level pendant to dt_device_get_raw_irq(). > */ > int dt_device_get_irq(const struct dt_device_node *device, unsigned int > index, > - struct dt_irq *irq); > + struct dt_irq *out_irq); > > /** > * dt_device_get_raw_irq - Resolve an interrupt for a device without > translation > @@ -652,7 +652,7 @@ int dt_device_get_irq(const struct dt_device_node > *device, unsigned int index, > */ > int dt_device_get_raw_irq(const struct dt_device_node *device, > unsigned int index, > - struct dt_raw_irq *irq); > + struct dt_raw_irq *out_irq); > > /** > * dt_irq_translate - Translate an irq > @@ -668,9 +668,9 @@ int dt_irq_translate(const struct dt_raw_irq *raw, struct > dt_irq *out_irq); > * @data: Caller data passed to callback > */ > int dt_for_each_irq_map(const struct dt_device_node *dev, > - int (*cb)(const struct dt_device_node *, > - const struct dt_irq *, > - void *), > + int (*cb)(const struct dt_device_node *dev, > + const struct dt_irq *dt_irq, > + void *data), > void *data); > > /** > @@ -680,9 +680,9 @@ int dt_for_each_irq_map(const struct dt_device_node *dev, > * @data: Caller data passed to callback > */ > int dt_for_each_range(const struct dt_device_node *dev, > - int (*cb)(const struct dt_device_node *, > + int (*cb)(const struct dt_device_node *dev, > uint64_t addr, uint64_t length, > - void *), > + void *data), > void *data); > > /** > -- > 2.34.1 >
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |