[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH 0/4] xen: address violations of MISRA C:2012 Rule 7.2


  • To: Simone Ballarin <simone.ballarin@xxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 26 Jul 2023 14:02:44 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RG9VRrX54zmq5tzgSL5KgTqxGYFT+5kJRwPkBC3Tx+Q=; b=NW7cWyLgj+Wl9EOS/Ml6gIQFayRY8XL120Y/l0WheSTa/JmpcVHoAjn8B2UAQcGPgoLIPH834mWc150oDrkDeO7flmZDbNrj55HhDsZnFEqyaR5yfZQbiRTde1JvEeMh8cMYxJw6LaFuSN5yZpQssYTlppmwrrWlHcHxPdJe9rH/t/fe4uEhrj9DlMmdCPG+Xh6Nkg7G4BuYZfA4ccSHBMydvwRqX4mBRAhRs6h/B4DQUyup/HsI3O6XtzZmyy7OOcqaY05Z39q7ow8bt7RDM1GEimdh4W/2C7Sm8IiBreNwJSnXP9TyP5cu5ZdSYf1G8mfV46vgEJ/px6OqRXSmBg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XG20joKvqirFTaCqE1USMXW+UEHo9/wejWM+phgtkdp6M63x0sYIDHgqM/VDrChdSHE1mkiebjvTEdFH8XlUmFILTdWRVX9EDmcFeLCeMbjy6eOd5DC2x0ab3ywhfhQJs3vbbh7quhWsWbixa8pMvIBSZ/5LCFS1y7peLk5U0VrSXu44IwyCmWdwsMfslWbDbuKjVzcFdn3w3ay3KgXlhKuBJjmwUZLjmbGLUK7C/vD1yKJHKMK+iVbVfMq+Gf4zD0axBY1fQueGN7c4kwhzbDL9ZGQ09Lhp1Nz2H2Ud9gtAJK0B5aJWAI/EmTLalrzczEeWh5umiav8i5EHHQpfnQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: consulting@xxxxxxxxxxx, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Paul Durrant <paul@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 26 Jul 2023 12:02:57 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 26.07.2023 13:03, Simone Ballarin wrote:
> The xen sources contains violations of MISRA C:2012 Rule 7.2 whose headline
> states:
> "A 'u' or 'U' suffix shall be applied to all integer constants that are
> represented in an unsigned type".
> 
> These violations are caused by the missing "u" or "U" suffix in unsigned
> integer constants, such as:
> 
> xen/arch/x86/hvm/hypercall.c:132.17-132.26
> if ( (eax & 0x80000000) && is_viridian_domain(currd) )
> 
> If a rule is not met, changes are needed in order to achieve compliance.
> The patches in this series achieve compliance for MISRA C:2012 Rule 7.2 by
> adding the 'U' suffix to integers literals with unsigned type and also to 
> other
> literals used in the same contexts or near violations, when their positive
> nature is immediately clear. The latter changes are done for the sake of
> uniformity.
> 
> Gianluca Luparini (4):
>   x86/vmx: address violations of MISRA C:2012 Rule 7.2
>   xen/vpci: address violations of MISRA C:2012 Rule 7.2
>   x86/viridian: address violations of MISRA C:2012 Rule 7.2
>   xen/x86: address violations of MISRA C:2012 Rule 7.2

Looks like this is v4 of a previously larger series, where fair parts have
gone in already?

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.