[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 3/4] xen/ppc: Implement early serial printk on pseries
- To: Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 26 Jul 2023 17:32:02 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=APNkYEc1Pe7otDgPHN053skWp7ycJiqiy0FuABNe7ds=; b=NTSk5k7Ouso3UgrvIckMsRED5ITrNKiEavJuKfMuCJbpKEprnhKpWKaQGgbqKfJP28JZq9lmADGsX2RKssC0wf8Dz6RmjhWnJAiXFY3mxzzY/fu+S0HTRbDAuJXBj2XSElRWwlVTtsrGEQPOxT/CuVVsUjl5LgjcVTWhsLpuvxqK8a/iO3VdyHQufWcABGk76HtsGk7MS1jkY3gA58jeYUxDsOK1E+GA3eHjq7yU/d+mHTyUwFy+df4F79SXqm6gkg0bR7XCNd431Io2nYZQzgawtJqNtiUpuRezkvCVQmxtcnZU7CNqwyQUsuBvHcZTI1Cnu+hZzMqW/1HTA3fgkA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KArKxr1HL3kau/2MquWtbpDr1IKwnD298WBQSEWJzniCvLyw2gV4oGebfJwJv357tz9RzSBRY9u6oOAtXjJZynYLL9AE9Sdi08xw1QYicpbyo2TVJdWmDHkvpMiESD984NHMZm940O8uSFcguIKR1fCvBOxkW3+RBrLwH39qQUe+kDfNUPxluks27Gg+g/AOEp/DfbKP4f0SurXIBHWXeAiwTSY/dpvFiy8WXMF7ymb4aVbzbUODTHNsRsuzzq2gd3CbnFS32hrU6kkhXD0BgQxTxx05BFLtijc82VRjtAR2+HZ9NFrrbYVFZ3khac8QsC+Jg00S350fbUer45tDfQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Timothy Pearson <tpearson@xxxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 26 Jul 2023 15:32:13 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24.07.2023 17:06, Shawn Anastasio wrote:
> On 7/24/23 7:40 AM, Jan Beulich wrote:
>> On 21.07.2023 19:02, Shawn Anastasio wrote:
>>> On typical Power VMs (e.g. QEMU's -M pseries), a variety of services
>>> including an early serial console are provided by Open Firmware.
>>> Implement the required interfaces to call into Open Firmware and write
>>> to the serial console.
>>>
>>> Since Open Firmware runs in 32-bit Big Endian mode and Xen runs in
>>> 64-bit Little Endian mode, a thunk is required to save/restore
>>> any potentially-clobbered registers as well as to perform the
>>> required endianness switch. Thankfully, linux already has such
>>> a routine, which was imported into ppc64/of-call.S.
>>>
>>> Support for bare metal (PowerNV) will be implemented in a future
>>> patch.
>>>
>>> Signed-off-by: Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>
>>
>> While I've committed the earlier two patches, I had to back out this
>> one. In my environment (gcc13) the build fails due an unresolved
>> reference to memset() out of boot-of.c (supposedly from of_call()).
>
> Does removing the `{ 0 }` initializer to `struct of_service s` on line
> 43 resolve this?
Yes, that's what's causing the call (and removing, whether or not correct,
helps).
Jan
|
