[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/HVM: drop dead assignments from hvmemul_rep_{movs,stos}()


  • To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Thu, 27 Jul 2023 16:27:06 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0DEsu9ew33VMzjUsHwNJnHOtsQNWIctiYtV4TzYL8X4=; b=oeMXfXVVK9vJIzKuGhyW/QHiZLjsoPdOj84ZOkNCDXBGDLqhyjXrBFGseiwYHObFFXXzsEAyeYcwMk+kZ4tPG6/db4/5Dgsy1XV/Eqc03+dDNrntBEVnX4ym0gIhsjFfAmkfha3hCqKXfn34Gc7zs2NnAG9TnoMqe/rqCNg3WCEbC8NdpnDO2DSH+x2P59no5a8MzNleJxX6yS0dX4UxV24O+r+ublS5jpVuInOPi7mgJ9fh5EfSW4WQsm3zQq2u1nucC6bAd+Ot2Hq0eHo3JQyXvujqwTegO/YFqBpSl2frFSLXIH94ruy7A/GgSZilHDaYcWemuZFisIxzZ0dS8Q==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NLtiVSzbP8sS35xO5Tyv5MXfJnpr4tMAafOtvHfuz7Lciv03NxwPROej6zjY+ZQgwFEx36GQVlGV9QZZx2yhUNWr/uCQrVxILH22D8VrJq2YKjyno5a5FDTH/NHkzQFLvDfhYz+BlLXxJh5kNXlJACzh64472LNb9ZmgOhwHZchWsFMS60gdYnuWzqbo7+TN2dYvpBbDM1Q/4CU+XZWCn7bg12NZSBh5sMbB3f+UDeXxnkZ/6QzahxqWmAYprKTEieSPNPRcw50PN7S6Pj2HHm7DFoqYZ2Cz0TWEK2XCPOe69HYQbwJTDS9E9j5JvdXFFDAcbBXkhIXLjIeH4ue/5w==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Paul Durrant <paul@xxxxxxx>, Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
  • Delivery-date: Thu, 27 Jul 2023 15:27:24 +0000
  • Ironport-data: A9a23:SNM8+Kk3+xBi7cStbdAnrb7o5gxCJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIbD2HXM6mNM2r2fItwPI60/E9U757Wz4RqQFA+qCFnEyMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE0p5K2aVA8w5ARkPqgU5gCGzRH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 c4XDykidSCfvs+zzbWEFNJdqu5/F9a+aevzulk4pd3YJdAPZMmZBonvu5pf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkV03ieexWDbWUoXiqcF9t0CUv G/ZuU/+BQkXLoe3wjuZ6HO8wOTImEsXXapLTuXip6I63wT7Kmo7CyRLTXiCpN2FzW3id+ltB Xc20TUnlP1nnKCsZpynN/Gim1aGtBMBX9tbE8Uh9RqAjKHT5m6xFmUCCzJMdtEinMs3XiAxk E+EmcvzAj5iu6HTTmiSnp+MpC62ETgYKykFfyBsZQ0E6N7nqcctgw7VT9BiOKSogcb4Hz62y DePxBXSnJ0WhM8Pkqm+o1bOhmv2ooCTF1FpoALKQmii8wV1Ipa/YJCl4kTa6vAGK5uFSl6Gv z4PnM32AP0yMKxhXRelGI0ldIxFLd7fWNEAqTaDx6Ucygk=
  • Ironport-hdrordr: A9a23:dhsCDqB1tj/LNYrlHelo55DYdb4zR+YMi2TDt3oddfU1SL38qy nKpp4mPHDP5wr5NEtPpTniAtjjfZq/z/5ICOAqVN/PYOCPggCVxepZnOjfKlPbehEX9oRmpN 1dm6oVMqyMMbCt5/yKnDVRELwbsaa6GLjDv5a785/0JzsaE52J6W1Ce2GmO3wzfiZqL7wjGq GR48JWzgDQAkj+PqyAdx84t/GonayzqK7b
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 27/07/2023 4:25 pm, Jan Beulich wrote:
> In the latter case the variable altogether is then unused and hence gets
> dropped, eliminating a Misra Rule 5.3 violation. I'm afraid I mistakenly
> introduced both assignments in 57a57465daaf ("x86/HVM: use available
> linear->phys translations in REP MOVS/STOS handling"), likely as a
> result of some re-work on the patch.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.