Re: [PATCH v3 10/25] tools/xenstore: add hashtable_replace() function

[Julien Grall <julien@xxxxxxx>]

Hi Juergen,

On 24/07/2023 12:02, Juergen Gross wrote:
> For an effective way to replace a hashtable entry add a new function
> hashtable_replace().
>
> This is in preparation to replace TDB with a more simple data storage.
>
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> ---
> V3:
> - fix commit message (Julien Grall)
> - move unrelated change to previous patch (Julien Grall)
> - make value parameter const
> ---
>   tools/xenstore/hashtable.c | 19 +++++++++++++++++++
>   tools/xenstore/hashtable.h | 16 ++++++++++++++++
>   2 files changed, 35 insertions(+)
>
> diff --git a/tools/xenstore/hashtable.c b/tools/xenstore/hashtable.c
> index 0409725060..f85b5a71f1 100644
> --- a/tools/xenstore/hashtable.c
> +++ b/tools/xenstore/hashtable.c
> @@ -205,6 +205,25 @@ void *hashtable_search(const struct hashtable *h, const 
> void *k)
>       return e ? e->v : NULL;
>   }
>   
> +int hashtable_replace(struct hashtable *h, const void *k, const void *v)
With the const dropped for 'v' and ...

> +{
> +    struct entry *e;
> +
> +    e = hashtable_search_entry(h, k);
> +    if (!e)
> +        return ENOENT;
> +
> +    if (h->flags & HASHTABLE_FREE_VALUE)
> +    {
> +        talloc_free(e->v);
> +        talloc_steal(e, v);
> +    }
> +
> +    e->v = (void *)v;
... cast:

Acked-by: Julien Grall <jgrall@xxxxxxxxxx>

Cheers,

--
Julien Grall