[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6 1/2] tools/console: Add escape argument to configure escape character


  • To: Peter Hoyes <peter.hoyes@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 28 Jul 2023 08:58:48 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N/wqsKL8vQV04Nox++dTtO1K4PL9AMVhbr1bFZyfuhg=; b=FyAlWm0fYCm7WEgJGwyEjw955fH137ZZFQTeubzrPVBQMbjP/fXtt91RA/aCbqKGC2eb2+DVIPNqdjM5Jb2REUYLPEQdXSeTOwFgTb8WFPw8IRs1WP8PoMf2jQ64uqoQkFZuGHsW/isBHwv/ILIzdLTL9xvd0ynN6mANJTUfgxxoLVVkeTGB3A3Toty1JieeGkjnrC/u88AY5ryuJ7Gh+XpCR0G9EXoROStEuwVN6oTAje5wGvOYD6qAgnqzg2SGbXbZUXKlFoZKmzNjX5ncszjHFYj6entAbatgxqqTFxbzIUTu226w6PbJgtk2XEQhjBKJIp7AfHTwTaJHQ23bQg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aSJio6c1+Q2dd7OqaQ5ish0K+juZgzGX0TLd4Ww9qFk5Fie1VmF0OTVoBWwW4PRoQQCysgu+hs5SXVfHlbaucjDwtbQrkTmUzn5zM4NxWKzGAh6oBl+rLeMGNCog0IuCmheVqkguZcnZgpFb6LkTIHlY21a4Tyebgdhd5qjoKsk7cFM3gMQ8NW8WjTQq4mvDsXa6Y99EpCwOA1vLHogOE+e6tlIz4LByom/hCFeobQaXazDkk4mPplpF4oAQTTd+F3dy4UdD2ywfozdGgTk45I88PC2KLtn7X/drKUSFRvLQPCrfwnTrI0KRSoPDfuFNQyIaRamRmeYGzl3ZfMo2dQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: bertrand.marquis@xxxxxxx, wei.chen@xxxxxxx, luca.fancellu@xxxxxxx, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Hongda Deng <hongda.deng@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Fri, 28 Jul 2023 06:59:03 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 27.07.2023 18:44, Peter Hoyes wrote:
> From: Peter Hoyes <Peter.Hoyes@xxxxxxx>
> 
> Dom0 may be accessed via telnet, meaning the default escape character
> (which is the same as telnet's) cannot be directly used to exit the
> console. It would be helpful to make the escape character customizable
> in such use cases.
> 
> Add --escape argument to console tool for this purpose.
> 
> Add argument to getopt options, parse and validate the escape character
> and pass value to console_loop.
> 
> If --escape is not specified, it falls back to the existing behavior
> using DEFAULT_ESCAPE_SEQUENCE.
> 
> Signed-off-by: Peter Hoyes <Peter.Hoyes@xxxxxxx>
> Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> Reviewed-by: Hongda Deng <hongda.deng@xxxxxxx>
> ---
> Changes in v5:
> - Add this changelog

Why the v6 re-post, when the v5 patch went in already?

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.