[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 4/4] x86/iommu: pass full IO-APIC RTE for remapping table update
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 28 Jul 2023 12:15:15 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BexjW4l+IbUnw7a6/ux2k+O8ya8lYbpw2mLoMEDJjn4=; b=mukr18NyLDQvOIIXGT0jSy+jo82fgP3kzqxNaBNRncsCL0UwzC3rjS7EftfJfNfRpNFrOMqfWfokjZ22/ybB8Xk61dlQmGs8oYl8uqmtyry4l5fv0cu9AYkLtpUtY2FODYenY4J7k0zKtv7biC3gyLJB4dB3HFedYX0Gi5AqEFv8O14yxrxO6eqNzECVznme10wi9/XAxEzhjBV3Z+YAmRgO0B77WOx3zTgZ0PCRtM1DxsYk0qTZSPqwGH7mMimX5m9bHD9ZzDCI40aY6+ik7A9jOrIAOZOrN2dwnd2PLlBRIHyEl36kxXhH76ueepsokbk6YThvs5+XzLXgFMsIhw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PPPF3O1Ik+/b9xHKA9cQIoxhdUN9eV+Ue78wpJzpM8YMwkFnNBTZXJJjNiYdHEVQLaH2qWAvCYM1KHx51jEs78UaYipIW2/VDY7hFWCULNVflbpF8lOrGRDjNGlvkEbC53o8fpXcwRZUP6tmYdtCIP2b/FqSKcfyKtT5S4ZX8stLyPS5Wf05YslmzinAxDe6SGCxyfHjYOcUTzCFIV+RnoC3QOpHl29lDunMTGNQu/HyhBG+VvVtKp0aXaN9J5PMj9CdqG1EQQ4dc6LfSo7wLCBlbBrkis4oNcUCphA+ZiG/AZv6LeMuTQeTkz8l6N13Fd5A0bqpKtkEHN19yMz9Rw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 28 Jul 2023 10:15:24 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 28.07.2023 11:57, Roger Pau Monne wrote:
> So that the remapping entry can be updated atomically when possible.
>
> Doing such update atomically will avoid Xen having to mask the IO-APIC
> pin prior to performing any interrupt movements (ie: changing the
> destination and vector fields), as the interrupt remapping entry is
> always consistent.
>
> This also simplifies some of the logic on both VT-d and AMD-Vi
> implementations, as having the full RTE available instead of half of
> it avoids to possibly read and update the missing other half from
> hardware.
>
> While there remove the explicit zeroing of new_ire fields in
> ioapic_rte_to_remap_entry() and initialize the variable at definition
> so all fields are zeroed. Note fields could be also initialized with
> final values at definition, but I found that likely too much to be
> done at this time.
>
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
|
