[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 2/2] xl: Add escape character argument to xl console
- To: Peter Hoyes <peter.hoyes@xxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Fri, 28 Jul 2023 11:44:27 +0100
- Authentication-results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, <bertrand.marquis@xxxxxxx>, <wei.chen@xxxxxxx>, <luca.fancellu@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
- Delivery-date: Fri, 28 Jul 2023 10:44:47 +0000
- Ironport-data: A9a23:dDEiRKBy7tgrDBVW/8Ljw5YqxClBgxIJ4kV8jS/XYbTApDlw32MFz 2FMCGGOM/feN2KjfdxxYdi08kxV68XQmtA2QQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbCRMsspvlDs15K6p4GxC7gRnDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw+ctwAzBh0 cUhIz02bz2kotKb57iVc7w57igjBJGD0II3v3hhyXfSDOo8QICFSKLPjTNa9G5u3IYUR6+YP pdHL2M1N3wsYDUWUrsTIJs4gOevgGi5azBCoUiZjaE2/3LS3Ep6172F3N/9I4XaHJQLxhzFz o7A10LoPD42P8bE8xyE2CONouzPoiTbA41HQdVU8dY12QbOlwT/EiY+TVanrOP/ikmvVsl3I lYRvCEpqMAa5EGtC9XwQRC8iHqFpQIHHcpdFfUg7wOAwbaS5ByWbkAOQyRdctUguIkzTCYzy 16St9rzAHpkt7j9YW2Q9/GfrT60ESEPKCkJYipsZQ8Y6NClrog1hR/LSstLGbSwyNbyHFnY3 DSivCU4wbIJgqYj1aqh+kvcqymxvZWPRQkwji3eRm+/5xl1TJKkbYevr1Pc6J59wJ2xFwfb+ iJewo7Hsb5IVMvW/MCQfAkTNLKE4PTUHxnluFViJJgM0BGd1lmpU7kFtVmSO3xV3tY4lS7BO RGC4V4KvcICYxNGfocsPdvvVp1CIbzIUI28C6uKNocmjo1ZLlfvwc14WaKHM4kBemAImLp3B 5qUeN3E4Z0yWfU+l2reqwvwPNYWKsECKYD7H8qTI+yPi+b2WZJsYe5t3KGyRu449riYhw7e7 sxSMcCHoz0GDrymPnmNr95NdgpVRZTeOXwQg5YKHgJkClM2cFzN9teLme9xE2Cbt/o9ehj0E oGVBRYDlQuXaYzvIgSWcHFzAI4Drr4mxU/XyRcEZA7ys1B6ONbH0UvqX8dvFVXR3LA5nKEco jhsU5noP8mjvRydpmlMMMej9dMzHPlp7CrXVxeYjPEEV8YIb2T0FhXMJWMDKAFm4vKLiPYD
- Ironport-hdrordr: A9a23:I+K0K69DZtNcaDQ7lUBuk+AoI+orL9Y04lQ7vn2ZKSY5TiX4rb HLoB1/73XJYVkqN03I9ervBEDiewK4yXcW2/hzAV7KZmCP1FdASrsC0WKL+Vbd8kbFh4xgPM lbE5SWc+eAamSTjazBkXWF+9RL+qj5zEh/792usUuETmtRGtBdBx8SMHf8LqXvLjM2f6bQEv Cnl7N6jgvlQ1s7ROKhCEIIWuDSzue76a4PMXY9dmYaABDlt0LS1ILH
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Jul 27, 2023 at 05:44:49PM +0100, Peter Hoyes wrote:
> diff --git a/tools/libs/light/libxl_console.c
> b/tools/libs/light/libxl_console.c
> index f497be141b..0b7293fe71 100644
> --- a/tools/libs/light/libxl_console.c
> +++ b/tools/libs/light/libxl_console.c
> @@ -75,15 +76,26 @@ int libxl_console_exec(libxl_ctx *ctx, uint32_t domid,
> int cons_num,
> goto out;
> }
>
> + char *args[] = {
> + p, domid_s, "--num", cons_num_s, "--type", cons_type_s,
> + NULL, NULL, NULL, NULL, // start-notify-fd, escape
> + NULL, // list terminator - do not use
So, you are going back and forth between C and C++ comment style, any
reason? The preferred style is '/* comment */' so previous patch was
better in that regards.
With the comment style fixed: Reviewed-by: Anthony PERARD
<anthony.perard@xxxxxxxxxx>
Thanks,
--
Anthony PERARD
|
