Re: [PATCH 2/3] x86/entry: Rename the exception entrypoints

[Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>]

On 28/07/2023 21:43, Andrew Cooper wrote:
> This makes the names match the architectural short names that we use
> elsewhere.  This avoids 'debug' in particular from being a global 
> symbol
> shadowed by many local parameter names.
>
> Remove the DECLARE_TRAP_HANDLER{,_CONST}() infrastructure.  Only 
> NMI/#MC are
> referenced externally (and NMI will cease to be soon, as part of adding 
> FRED
> support).  Move the entrypoint declarations into the respective traps.c 
> where
> they're used, rather than keeping them visible across ~all of Xen.
>
> Drop the long-stale comment at the top of init_idt_traps().  It's 
> mostly
> discussing a 32bit Xen, and bogus otherwise as it's impossible to use 
> trap
> gates correctly for these purposes.
>
> No functional change.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> CC: Wei Liu <wl@xxxxxxx>
> CC: Roberto Bagnara <roberto.bagnara@xxxxxxxxxxx>
> CC: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
>
> This is half of a previous patch, cut down to just the rename and 
> header file
> cleanup.
> ---
>  xen/arch/x86/include/asm/processor.h | 34 +-------------
>  xen/arch/x86/pv/traps.c              |  2 +
>  xen/arch/x86/traps.c                 | 70 +++++++++++++++++-----------
>  xen/arch/x86/x86_64/entry.S          | 36 +++++++-------
>  4 files changed, 64 insertions(+), 78 deletions(-)
With respect to Rule 5.3:
Tested-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>

--
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)