[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v3 1/2] build: evaluate XEN_BUILD_* and XEN_DOMAIN immediately
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 31 Jul 2023 12:49:32 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lUk93vsUukG1wnuqMAPjhSR8qVbloAaxMzKJwZ+rd2U=; b=oKQUiZtOvl9u1rhCqInfCVGy8XuB3gfOUP5NXe3Y1jf50RGzBBNIeHxKBRH+c8ENpp5cEg+WIakFeRKSBTWNZMgM+Ds24F2LzhBCxG+79LTCu6BzVRIcAWRh9eAYQxlWliZV5Y8OUL91YHIZt/q5g3RJF68uj4hrDZnqIf+D0QE7IVnCDxi0IZVApZK9T+apCthprteai/kd4EyMpJqP1PVyZl7PDofbWxQLQnuckJEq2J9oRtsbmAKoeAbFZB/g1fLC5dwQXPq5ErJZTzpQ93q/B70k1Txk0uZPlmmLjgETXJAQCImEA+M9UC7IKs5Dmm1qZ0hQJ3249PCkRfUvFA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cl6BAjux2KMwvVqM+QUQg1KnSdtEcKcvh7wa20NH3b7DksHxUFxXiAWrMl/dsbMY9Yj/R0UG1N2yP8DhgwijRHRK2zETIjgs6uElKVBXJrBoIC5dsFzLAubc0c7JmgcMw4vHoVwFDZ60rhT6rn88uL/IgE+TtVhKKlDzBUOscddf2q1I1A9xqCvRRGrq8jwwfRq3ZlaP/AbUBKb7I7WorJzWQRtm4I4Q35fgiTanW6WWXqClqA0Us1ewwt5GzbdvSl6BKHQsdD3ZTJO1MJUB/mTVeZjQw+pBQVOFGoD0mIyqvySnqSwlAPBi7Fu3EHsOfk2pBUqQFATpawzzRs4pHQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Jason Andryuk <jandryuk@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 31 Jul 2023 10:49:44 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 27.07.2023 16:54, Anthony PERARD wrote:
> With GNU make 4.4, the number of execution of the command present in
> these $(shell ) increased greatly. This is probably because as of make
> 4.4, exported variable are also added to the environment of $(shell )
> construct.
>
> Also, `make -d` shows a lot of these:
> Makefile:15: not recursively expanding XEN_BUILD_DATE to export to shell
> function
> Makefile:16: not recursively expanding XEN_BUILD_TIME to export to shell
> function
> Makefile:17: not recursively expanding XEN_BUILD_HOST to export to shell
> function
> Makefile:14: not recursively expanding XEN_DOMAIN to export to shell
> function
>
> So to avoid having these command been run more than necessary, we
> will replace ?= by an equivalent but with immediate expansion.
>
> Reported-by: Jason Andryuk <jandryuk@xxxxxxxxx>
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
|
