Re: [RFC PATCH 1/5] [WIP]misra: add entries to the excluded list

[Jan Beulich <jbeulich@xxxxxxxx>]

On 28.07.2023 10:11, Luca Fancellu wrote:
> Add entries to the exclusion list, so that they can be excluded
> from the formatter tool.
> 
> TBD: add a field on each entry to understand for what tool is the
> exclusion
> 
> Signed-off-by: Luca Fancellu <luca.fancellu@xxxxxxx>
> ---
>  docs/misra/exclude-list.json | 88 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 88 insertions(+)
> 
> diff --git a/docs/misra/exclude-list.json b/docs/misra/exclude-list.json
> index ca1e2dd678ff..c103c69209c9 100644
> --- a/docs/misra/exclude-list.json
> +++ b/docs/misra/exclude-list.json
> @@ -1,6 +1,10 @@
>  {
>      "version": "1.0",
>      "content": [
> +        {
> +            "rel_path": "arch/arm/arm32/lib/assembler.h",
> +            "comment": "Includes mostly assembly macro and it's meant to be 
> included only in assembly code"
> +        },
>          {
>              "rel_path": "arch/arm/arm64/cpufeature.c",
>              "comment": "Imported from Linux, ignore for now"
> @@ -13,6 +17,26 @@
>              "rel_path": "arch/arm/arm64/lib/find_next_bit.c",
>              "comment": "Imported from Linux, ignore for now"
>          },
> +        {
> +            "rel_path": "arch/arm/include/asm/arm32/macros.h",
> +            "comment": "Includes only assembly macro"
> +        },
> +        {
> +            "rel_path": "arch/arm/include/asm/arm64/macros.h",
> +            "comment": "Includes only assembly macro"
> +        },
> +        {
> +            "rel_path": "arch/arm/include/asm/alternative.h",
> +            "comment": "Imported from Linux, ignore for now"
> +        },
> +        {
> +            "rel_path": "arch/arm/include/asm/asm_defns.h",
> +            "comment": "Includes mostly assembly macro"
> +        },
> +        {
> +            "rel_path": "arch/arm/include/asm/macros.h",
> +            "comment": "Includes mostly assembly macro and it's meant to be 
> included only in assembly code"
> +        },
>          {
>              "rel_path": "arch/x86/acpi/boot.c",
>              "comment": "Imported from Linux, ignore for now"
> @@ -69,6 +93,30 @@
>              "rel_path": "arch/x86/cpu/mwait-idle.c",
>              "comment": "Imported from Linux, ignore for now"
>          },
> +        {
> +            "rel_path": "arch/x86/include/asm/alternative-asm.h",
> +            "comment": "Includes mostly assembly macro and it's meant to be 
> included only in assembly code"
> +        },
> +        {
> +            "rel_path": "arch/x86/include/asm/asm_defns.h",
> +            "comment": "Includes mostly assembly macro"
> +        },
> +        {
> +            "rel_path": "arch/x86/include/asm/asm-defns.h",
> +            "comment": "Includes mostly assembly macro"
> +        },
> +        {
> +            "rel_path": "arch/x86/include/asm/bug.h",
> +            "comment": "Includes mostly assembly macro"
> +        },

Mind me asking why assembly macros wouldn't want maintaining in proper
style?

> +        {
> +            "rel_path": "arch/x86/include/asm/mpspec.h",
> +            "comment": "Imported from Linux, also case ranges are not 
> handled by clang-format, ignore for now"
> +        },
> +        {
> +            "rel_path": "arch/x86/include/asm/spec_ctrl_asm.h",
> +            "comment": "Includes mostly assembly macro"
> +        },
>          {
>              "rel_path": "arch/x86/delay.c",
>              "comment": "Imported from Linux, ignore for now"
> @@ -181,6 +229,42 @@
>              "rel_path": "drivers/video/font_*",
>              "comment": "Imported from Linux, ignore for now"
>          },
> +        {
> +            "rel_path": "include/efi/*.h",
> +            "comment": "Imported from gnu-efi-3.0k"
> +        },
> +        {
> +            "rel_path": "include/public/arch-x86/cpufeatureset.h",
> +            "comment": "This file contains some inputs for the gen-cpuid.py 
> script, leave it out"
> +        },
> +        {
> +            "rel_path": "include/public/**/**/*.h",
> +            "comment": "Public headers are quite sensitive to format tools"
> +        },
> +        {
> +            "rel_path": "include/public/**/*.h",
> +            "comment": "Public headers are quite sensitive to format tools"
> +        },

The common meaning of ** that I know is "any level directories", but
since you use **/**/ above that can't be it here. Could you clarify
what the difference of */ and **/ is here (or maybe in JSON in general)?

Jan