[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/5] xen/ppc: Switch to medium PIC code model
- To: Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 31 Jul 2023 17:58:40 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BCz0ZMv0rjcF8ceu2MJXy/aHsqYv5b8g9VU76qBIgaI=; b=A4qZ0AtPAnRTK5OBw/Th3M7YEuiwUKHYJeWWtAOXQqoqF8rd6zwz3+xYJJ7CcGTeNmaLfto9WzGUTYM9jsSBRtSaltSRpA8hT7XjRQRusbyiX2u3TTbAXa99rKOvaS0Gk9etBSA96ZRdl+4k5wXoL7wk7/4i4zFzddJWj0KkYFfAj2F5jspHajoPLTbVU0fhC/gLXl0yWMA5TuBrb6pGhLx06OzbWghpRcXrh1JGxqZ/tKni6/4JBtDJ6WQq73jxwL4xNecLS7uLPrgZmjuyS1zB6+n4ALilSMBJnijei/J6+l4kx6kQp/NqBVyB8+eDxnWxRnqL8YylMuH/D5ePYg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KKNBCVaDZBXTq8EhSQKJzu07gGoxif4PnsKVg3e0xED1MfIroZNjPcgmN2p/5wEn+BKu14e5gVa/pykClnIFV5FHypaAPBFp+bzljw9yZn+7eZZr2p8Y0LdC8fHrCA6eXRiKOCxmIFRyMg0/3Xt1Ycndr+PRjqyizS1YQbRQnWi/offR0DTjviUOCsByiwCw8w1DwVCY3C6kCPLNrLsxU55n5/wQ/72UWqxGbvkQsSIMlFBkSVl1TUMOKbK2LBC6k6zV+yAR178qnmeNVS3X3YV3sZehRxbV25VWsCrj7SrD123RpSA1YWfXoErdI6G94PLIVmMHHTwSOO8I5J0InA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Timothy Pearson <tpearson@xxxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 31 Jul 2023 15:58:57 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 28.07.2023 23:35, Shawn Anastasio wrote:
> --- a/xen/arch/ppc/ppc64/head.S
> +++ b/xen/arch/ppc/ppc64/head.S
> @@ -1,9 +1,11 @@
> /* SPDX-License-Identifier: GPL-2.0-or-later */
>
> #include <asm/asm-defns.h>
> +#include <asm/asm-offsets.h>
>
> .section .text.header, "ax", %progbits
>
> +
> ENTRY(start)
Nit: Stray change?
> @@ -11,16 +13,19 @@ ENTRY(start)
> FIXUP_ENDIAN
>
> /* set up the TOC pointer */
> - LOAD_IMM32(%r2, .TOC.)
> + bcl 20, 31, .+4
Could you use a label name instead of .+4? Aiui you really mean
> +1: mflr %r12
... "1f" there?
Jan
> + addis %r2, %r12, .TOC.-1b@ha
> + addi %r2, %r2, .TOC.-1b@l
>
> /* set up the initial stack */
> - LOAD_IMM32(%r1, cpu0_boot_stack)
> + LOAD_REG_ADDR(%r1, cpu0_boot_stack)
> li %r11, 0
> stdu %r11, -STACK_FRAME_OVERHEAD(%r1)
>
> /* clear .bss */
> - LOAD_IMM32(%r14, __bss_start)
> - LOAD_IMM32(%r15, __bss_end)
> + LOAD_REG_ADDR(%r14, __bss_start)
> + LOAD_REG_ADDR(%r15, __bss_end)
> 1:
> std %r11, 0(%r14)
> addi %r14, %r14, 8
|
