[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] arm32: Avoid using solaris syntax for .section directive


  • To: Khem Raj <raj.khem@xxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 1 Aug 2023 09:33:23 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7OMh/x05/42TX1QWERn3Tnku7+pQOTwbHOS3lypRLzI=; b=nPFJao3AeV6tqZsJjbdb360mhxiYHX58srbWMKo0HUFxw7gcfI3StirsT1vXsigLPZKUJ6tYxQR0l65ULFDaYvCP1qzg76Bx+xy195Vm+KLEUKiDwFXpHi/EjmHLSbJnjW9yIKGIFQnk+QT2FuYdTWiETDeP9UGL2xJdMf6Ff3hRtYHSW3oAxVz2StaxbX2xM+QoeiaebkZDhnNDIl7ih4JK4+Q+YubjaMWdY+ya0D92+IUONjZSwDCjbwd0Di4SCiFs4ZdFaoZkjbxr+I+MFbvJFCCQsRV1brfNIfPieG3OeDRekDXHsZmUn3GebDz9ScOTLNL+GC5YniVmTJ2GWw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hgBX+mx2XlbVoC4sJxuKCOEyYGozJsj3+ulWYHH2Zg4v9C2icRfJJxjt7W2IvhKEghOnZTQQnCKezSWlnnA9CzSb61DXSKp/XhUYxB9ic7uM+bvPaJVjoTbTH/vcnAJrVwEjQs0R2oD/HQhuZPvOFDan6H6Mdsx2rp2TO5/m3HvS1uuqnt7CYBpNi1ekr0S8Yd1OQrvZmLbehRVYv0lFBbHXOwumMna9nvKnZtYSxYwCRMXS4Ge2Wj0FLY7Yh+JxEsqsHyMLjIN9sEKXqZecS3Ms7no44b18aok5gyEvVr6zSRUSRGqyiHCGWIqIXQzWq/ttiSCWXNkzdqJOVg90TA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Tue, 01 Aug 2023 07:34:07 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 01.08.2023 02:12, Khem Raj wrote:
> Assembler from binutils 2.41 rejects this syntax
> 
> .section "name"[, flags...]
> 
> where flags could be #alloc, #write, #execstr
> Switch to using ELF syntax

You mean GNU, not ELF (ELF is describing the object format, not the
syntax used). Feels almost like a regression (I'll mention that to
Alan), which likely went unnoticed so far because Linux had changed
to GNU syntax already in 5.5, to allow building with Clang's
integrated assembler. This aspect may be worth mentioning here as
well.

> .section name[, "flags"[, @type]]
> 
> [1] 
> https://ftp.gnu.org/old-gnu/Manuals/gas-2.9.1/html_chapter/as_7.html#SEC119
> 
> Signed-off-by: Khem Raj <raj.khem@xxxxxxxxx>

Out of curiosity - why were there four instances of the patch?
They all look largely identical; if there are differences, I haven't
spotted them.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.