[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 1/1] ns16550: add support for polling mode when device tree is used
- To: Oleksii <oleksii.kurochko@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 1 Aug 2023 11:59:50 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sy2fHjwQKHBfHzb7HKzlmPo3cQ4nWBIyPbHqvTuASvM=; b=mK9DDPT127gI5dLLOZOZB0XUsKe82EFhIBkdUAOf8vyOgL2nRiqx8Bba5tCKvZbTUr1MCSB7hPUAfXWZoh6rKyioiwkC4RfW7DZUjRrKiveZ0NWhAKxkkh/RhVGRZLg9xzk8Ntx0UVJYSzK8qOyEiDrJcfrLRDnlUdM4jewgLxh/Ooegteehy7RIXV/oHrPRuVPBQ+PwvDmAD/bwZOHNi/7G8zCiiKvo2OomB/y0TllY1AZY0pYTh/pZQqHAjYc2oABceMXntubMk+4wmAIMAybPxNN50pVDWd9ZUo7AQ45L2uPfURcqLFYfAlNHUlF1f/7TZZ3OHqkshuOkUYR/tw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h4VofkmLQJnVK7TtnIiTIP+LEq4uKurD2dvb0A+tzBbPFSF5FzphGjAALSC7uEHEZhgv1A6ToU96MDbEQ1UdREGVnFZGlPGBkNRiFXG04inxAYgPOAdu9KEN7WPLArXb3CKOfh1+1YXGPkXF/f6EmoVHrWh7x2Z2Z9OK0BqAoEDaJcSlK0P3mSi9xS3SrgUPwnD6PcjK7bwAmFKNNlAAoSyWPzoVWn2FSOOTWlDRqxKWCrT82pw/zOK4onkeZQLiSAu2XZHux3xCHq8T27gv1vaC+HbJ0oJ2hbxt9tLvQsWq70Vhk8JqI3KD4I0j2/V4aF/B27XAzRbQ9hsGTgdqDw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 01 Aug 2023 10:00:01 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 01.08.2023 11:46, Oleksii wrote:
> On Mon, 2023-07-31 at 15:24 +0200, Jan Beulich wrote:
>> On 27.07.2023 18:45, Oleksii Kurochko wrote:
>>> @@ -654,6 +674,9 @@ static void ns16550_init_common(struct ns16550
>>> *uart)
>>>
>>> /* Default lsr_mask = UART_LSR_THRE */
>>> uart->lsr_mask = UART_LSR_THRE;
>>> +
>>> + if ( strstr(opt_com1, "poll") || strstr(opt_com2, "poll") )
>>> + uart->intr_works = polling;
>>> }
>>
>> A non-__init function may not reference __initdata objects. But
>> strstr()
>> is too lax anyway, and you also shouldn't check the wrong port's
>> options.
>> You want to recognize "poll" _only_ where all other command line
>> options
>> are processed.
> Just to confirm, do you mean that I should use parse_positional() ( or
> something similar ) for the device-tree method of initializing ns16550?
>
> I checked the polling behavior as described above because
> parse_positional() is utilized solely for X86.
>
> It appears that command line options are parsed only in the case of
> x86.
Hmm, looks like you're right. Arm folks will want to clarify how they
got away without any command line overrides so far, and how they think
now necessary ones should be suitably added. I recall I had reservations
when the file was massaged to compile out supposedly x86-only code.
Jan
|
