[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH] xen/spinlock: address violations of MISRA C:2012 Rules 8.2 and 8.3
- To: Federico Serafini <federico.serafini@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 1 Aug 2023 15:50:22 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FvPg3IhUWh1TBgh1T8s3jZPBueX+NMrRIifczvw5C3Y=; b=HImhE4ZK2rePLlOv0tzG9StXiggxTOtIPMJ54RLXICXNpeFG+3hvuILtW/faR5ej8XmDTSTiAYjZNiY4HE9b/7u0X3e3g43cclpxYr6tFda9bPOrayAj8D4Hu2S3SAN3z7tQiIEYL2H55zE2O0nad/DgTmhtm/SaPsSbWmMl43w3wlSxFPSTxTnKjvwamlmHvoMFyubo+svQ2UV/ETnq7QAhzXDUYgU8Kg8ehRE0gbazVMxTJxtz6eJ+HTMrrgUWQc9xzqP5oniyEcACxzDH3aHePcmgXcCInEOi6g+AXj1Aw4KL5gzHoONqrzweiMmjyUjoNNoqhGOIp2Y1TmG/Ww==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ckfpZ6uavn+QeeLKX72g41Fc4uEp3MkUfJkMbXyx81uzXWLOWVLUI868t0T5UWbsA8x0x/VIYlGxYh3kVK3qmkV61fUNcwF/DPnPP6TISR+sKp0cT4YonBjMryrcqrFUWb3MtyY74GP42Xk7mXpcO36pJd7/eZdSSs4FzRJQpf1aw2R8vVw5YuXoOz1g+mQJOndIs5/gJqWlkwaiFj7CJm1ySsW+vfxKvIdyrA0FIFcG8cEVYMQFgzeq5U3kruGQUaKQETlpm4hzEaA1t6nBQvoe1BoP01V/7T1jRffM/D28brQzMVxAhAgYgIw59eoS/cyiYLf3vxG/pYt8Pezeqg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: consulting@xxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 01 Aug 2023 13:50:31 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 01.08.2023 11:46, Federico Serafini wrote:
> --- a/xen/include/xen/spinlock.h
> +++ b/xen/include/xen/spinlock.h
> @@ -125,8 +125,9 @@ struct lock_profile_qhead {
> } while(0)
>
> void _lock_profile_register_struct(
> - int32_t, struct lock_profile_qhead *, int32_t);
> -void _lock_profile_deregister_struct(int32_t, struct lock_profile_qhead *);
> + int32_t type, struct lock_profile_qhead *qhead, int32_t idx);
> +void _lock_profile_deregister_struct(int32_t type,
> + struct lock_profile_qhead *qhead);
In adjacent declaration it would be nice if the same line wrapping
style was used. Can surely be taken care of while committing. With
the adjustment:
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
Jan
|
