[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 2/2] xen/riscv: introduce identity mapping
- To: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 1 Aug 2023 16:50:25 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Gs1JOrX2quhXPpOm/hsB2Y/9bXV8kVqK94dVS7bKTWY=; b=NvbooTn/81BL+u/Fsrd7NLGr0MA+cyzCepFKahPBbtjTRjOKWVFG9D8OF3G5XXEfa+hUddd+CsxLDL4UJFlAfjQeFk6xSwIWgz6uwikRh1uag0RxkpuaxKLvYPLd5ef2vjLi1Q6ABr2vLdOAG5H3+V8BpgI3x3K3oBsJmxdcEaiWXW5l1xIHWydi9Rql4JwjHgKuhbvrT1V87/ZI/rtVeEwKWGDq/3jpA9HYu9ItxSCRwgHGOPCbi5u/ftNhOHE/zyD07eqZ4B2Cv+U3oK6we8BhZBAdXs2Lp4Mm2TZyUewudJW7VQe4aFXLgqUVQXIqPip/av3xFs2LyDEoAijyrQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cB5X9TaytQilnF7vBZiIiZ40c4ZHlcvtsQNSjcq8lcLgWcdrvNzEOh5GOmIuSD8FfnbROZCy5QcZk2rIeySQq+z910d54Mg50c3e1F13iMxD97ZhFGaZSxzW3APRGw196ZNe6pR0HPqh27AJrhnm4BUEuYWIp5vXx7S67HgIHePRxLbfImnIOv/z0StGEHw4qv1nDcdX6FxF6wwGkutnFUqaEL7fxU2/T/tbvOiAiycy1PrXVBVjSMGPp2CHIFba/iox2Rj4uKWzMdliEvi1ZhaNoCUPymPBYk3BvaYxUHDFSaGU26dYuXaVCx7B4Mc38Aba9rRic1r11P0ewtk4QQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 01 Aug 2023 14:50:42 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 01.08.2023 16:30, Oleksii Kurochko wrote:
> @@ -54,3 +70,17 @@ ENTRY(reset_stack)
>
> ret
>
> + .section .text.ident, "ax", %progbits
> +
> +ENTRY(turn_on_mmu)
> + sfence.vma
> +
> + li t0, RV_STAGE1_MODE
> + slli t0, t0, SATP_MODE_SHIFT
> +
> + la t1, stage1_pgtbl_root
> + srl t1, t1, PAGE_SHIFT
I think it would be good to be consistent in the use of pseudo insns:
Above you use slli, so here it would want to be srli (or the other
way around).
Jan
> + or t1, t1, t0
> + csrw CSR_SATP, t1
> +
> + jr a0
|
