[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v4 00/13] xen/arm: Split MMU code as the prepration of MPU work
- To: Julien Grall <julien@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Wed, 2 Aug 2023 03:59:13 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6pPRehJouAJ14zJDuwpjJGN2EJjKr4+iWJK4Lzd6pvo=; b=FQbnyT2UIqcHPOnjV6Wkko5BX30HKGG2UdBc4eDPfpUUMuYNuylbCoTgRz8L4Q8y8/wAC93BhKgUWIBLw6+TevFIqv6w3mLK7NUcAZJiC74XS8MK07eWoJ6SFL9qZx9IgEaPiqF1CKQEnJcqdeJu9cH3bDoABZgnEHYbN/lZ1eMcGHU0KB5zGmk/66klfsj+j3921dpM4IT4ylvf3qc/nCyLXuzFa9+4dHYjOY8MB/tbZpR5bLyQ4ZDqrLLdLEUoR01sNQcRty3pf3VbXaXQ0oGiXSxLIDb11nOFkzNijv6ryBClRMpDLIi+e5EzAFHhi9Uv7bxMI0vrcwXCXpGf1Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JQ7hy4kt3MOBvJpIkl2UMzoPI11BxW+LEYL7nLhX2dzYc62LJy7dqM6AVLWkXFTmO3JOTaEfQAj8akwvJFJ/Ne5EHf5oiNSrJngSTbuuxyeW+FM6N1zi2Js8FsjgBhuaS5URaZ9LuRvU/W9pE6IG1P5BFdGEJEaWQlDDM/NPqOcfPRNIi3CzZSF2gtowbsJOJbKx0LcGgmkZIAzWSgXdOdAeNAyz434iVqcvoRcuOOWRsp8Ctj+s1PUx1KSRVYZL+/+TCL3r36C/HR6xrZGivIjM4hThDKi7B4DZ2qQRdKvel1wgHo/MoRrIP259msv2+DMylwccdL2en1yANiqv2w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Penny Zheng <Penny.Zheng@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Wed, 02 Aug 2023 03:59:40 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHZxCqGkXVqhatOiEqMa3qeqTOTXK/VHIIAgAEp0BA=
- Thread-topic: [PATCH v4 00/13] xen/arm: Split MMU code as the prepration of MPU work
Hi Julien,
Thanks for your prompt response and your time on the review!
> -----Original Message-----
> From: Julien Grall <julien@xxxxxxx>
> Subject: Re: [PATCH v4 00/13] xen/arm: Split MMU code as the prepration of
> MPU work
>
> Hi,
>
> On 01/08/2023 04:44, Henry Wang wrote:
> > Based on the discussion in the Xen Summit [1], sending this series out after
> > addressing the comments in v3 [2] as the preparation work to add MPU
> support.
> >
> > Mostly code movement, with some of Kconfig and build system (mainly
> Makefiles)
> > adjustment. No functional change expected.
>
> I can't really review this series without knowing how this will
> integrate with the rest of the MPU work.
Sorry about it, I should have asked before sending the series.
> Can you at least provide a tree
> with all the patches applied (including the MPU one)?
See [1] for the full single core MPU implementation which I've verified
locally about the MMU and MPU single core Linux boot on FVP, and
looks like Gitlab is also not complaining [2].
Note that I've addressed comments from you and Ayan in v3 about the
MMU/MPU helpers duplication and the arm32/arm64 split work. I didn't
address the comment in [3] about the RES0 stuff, but I think this is not
related to the MMU split series I sent yesterday to mailing list and the
formal v4 MPU work sent to the mailing list will contain the fix for this
comment.
[1] https://gitlab.com/xen-project/people/henryw/xen/-/commits/mpu_v4
[2] https://gitlab.com/xen-project/people/henryw/xen/-/pipelines/952742025
[3]
https://patchwork.kernel.org/project/xen-devel/patch/20230626033443.2943270-32-Penny.Zheng@xxxxxxx/
Kind regards,
Henry
>
> Cheers,
>
> --
> Julien Grall
|
