[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] arm32: Avoid using solaris syntax for .section directive
- To: Khem Raj <raj.khem@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Wed, 2 Aug 2023 08:45:13 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=gmail.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p8182KY+n3aHnqyfWZHGhA1CwEz6eV9ppeOvRRMd53U=; b=bQuxqHWbtWpgUImvOgV/gQhPVEXuqAeX/hmQoxygsmOi3R0HBzw5z7vu9+IQGaMMJ7CBvUgBhRh9K0d7a0dN2d+2UxhIEuevF/CMKpQsrVrRjVD5dqfKOwFnW+YPaxVS86aICHn/5EMHp/iK73PrTOzfoba/OXviADGyCgrdrA/VixYJiyk1ccfE4ZxDmqF/XEx9O6yflTBrGxTcSb/srCqpfkUf3F7nhVD1U3mDWV3aroz9l3diYaGr/kiB/ApSaa0axfVicVsrADDsF3s18G7V1UfeA+VURovKqCraZJdsVK8SgEjUtcyCKHreQdi6rH/tHbRefv5G4WeY/3Yp1g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DaYqJA3aOBpO647RufGyZbp1dCMaGMOg/2Ovh07jw5pYqtPEPh98tnrIJ3YQPXUCvtbn+xWs+14JvIIp9AGTo0TaNbzPexj89NcYJNZ1M07DUOy0W79PzR8ed4UU3HSrpqW9Z6/XW4bKG5yRz8H88ecu5GlZFZclUMrz+JhKFGB0RdvtxV0OuRAeB7gVwfjBnkZN6FsC/1amaGy/SknsjEuL86Hwb51PcinYhKKgCqmpbytGvpYPUctUEfd11vOs66KscjX5OIXVc6ROC3HmKqOKAegcL7ufvirt5Zzd7/TuFMEaKPdHlEYT19rmzqfxmHscicIqvRL0n1dmmj5iCg==
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, "Volodymyr Babchuk" <Volodymyr_Babchuk@xxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
- Delivery-date: Wed, 02 Aug 2023 06:45:32 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi,
On 01/08/2023 19:49, Khem Raj wrote:
>
>
> Assembler from binutils 2.41 rejects [1] this syntax
>
> .section "name"[, flags...]
>
> where flags could be #alloc, #write, #execinstr, #exclude, and #tls [2]
>
> It is almost like a regression compared to 2.40 or older release,
> It likely went unnoticed so far because Linux kernel changed
> to GNU syntax already in 5.5, to allow building with Clang's
> integrated assembler.
>
> Switch to using GNU syntax
>
> .section name[, "flags"[, @type]]
>
> [1] https://sourceware.org/bugzilla/show_bug.cgi?id=11601
> [2] https://sourceware.org/binutils/docs-2.41/as.html#Section
>
> Signed-off-by: Khem Raj <raj.khem@xxxxxxxxx>
With the changes suggested by Julien:
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
~Michal
|
