[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional
- To: Luca Fancellu <luca.fancellu@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Wed, 2 Aug 2023 16:26:58 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nohBqLPQWx4dTuM4PWNJLXKTSyzFHK5QNQ1WRz6kULU=; b=Hq0z+OIyfGgsy8v0yk1xwcqZwAR7i/Xh/0rk8toGGRUSpDy7q0GxXIwcaY/CkpbOQerQpWwSW4uqO/1wk30BSnSPAj5yGM3Or3fiV0Qj5O+NAeB/k9/TGuLN6J5n6JLb+jdwISyGtVh/JIX+PloGQMNgQsDcTjCCliUzKtuKlOhKDdJhyefcR2zeiOvWpmw+I3urevcqyPyu56tYZx+RnpfPJYl/DlwxnEZpuZ4ya2IiOIu1JsoQ9wfjoBiaNUpzFj0bZcUafGOowCc2sHDHAtpW9dVxWkK1R4LX74pUcU/QIOjESWbLhL7g6gWcmgB5cs1I4wiO3FNbebtUFb+ToA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ETz/y/5ay50DkvE2BIq4agIte2RKPTrnT0tov1tfnvICvtV7/I8Oz6HQy4aotq4xkDWWKPGPTNpNuYbV8xMJqYH/yvtVKpV0mSp29t7WAPxlwbXafMExUhoqsW3vlGBWFfgZEv5I+uCKi1OpEJVY6Z94TAsa+0vg9lr99jmjQnDj4t0UyYf0tVw0WWVkOqDXhd8AM3H1k3pmKF6bp9OjuO/oFcb6RxO7x3AYca/7yXQwVRffmNHn2ZiWG0Hf21bPnmWvf80FJkO73cvhkStFGfmHGJjOM8cKJnriRC1QmzJZ6WAlMNVWqvFfXarvip1/hZVhCBSTc5L0RDRdTthL0w==
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, "Volodymyr Babchuk" <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Wed, 02 Aug 2023 14:27:23 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Luca,
On 02/08/2023 15:53, Luca Fancellu wrote:
>
>
> Introduce Kconfig GICV2 to be able to compile the GICv2 driver only
> when needed, the option is active by default.
>
> Introduce Kconfig VGICV2 that depends on GICV2 or GICV3 and compiles
> the GICv2 emulation for guests, it is required only when using GICV2
> driver, otherwise using GICV3 it is optional and can be deselected
> if the user doesn't want to offer the vGICv2 interface to guests or
> maybe its GICv3 hardware can't offer the GICv2 compatible mode.
>
> Signed-off-by: Luca Fancellu <luca.fancellu@xxxxxxx>
> ---
> xen/arch/arm/Kconfig | 13 +++++++++++++
> xen/arch/arm/Makefile | 4 ++--
> xen/arch/arm/domain_build.c | 4 ++++
> xen/arch/arm/gic-v3.c | 4 ++++
> xen/arch/arm/vgic.c | 2 ++
> 5 files changed, 25 insertions(+), 2 deletions(-)
>
> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> index fd57a82dd284..dc702f08ace7 100644
> --- a/xen/arch/arm/Kconfig
> +++ b/xen/arch/arm/Kconfig
> @@ -78,6 +78,14 @@ config ARM_EFI
> UEFI firmware. A UEFI stub is provided to allow Xen to
> be booted as an EFI application.
>
> +config GICV2
So, now it would be possible to deselect both GIC drivers and Xen would not
complain when building.
This means that Xen would fail on boot without any message as it happens before
serial driver initialization.
Since having GIC driver built in is a must-have I think we need to make sure
that at least one is enabled.
~Michal
|
