[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/2] fdt: make fdt handling reusable across arch
- To: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Thu, 3 Aug 2023 20:37:40 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wcgjQduBKAKOmnCmHicghrNByM6XK2eP+K7MyTSqdMY=; b=NQxMImSIf1O4E1Ws9Tbr4gXTTP4U9+298Q73CXVlI5n3xIOPTOQAgKv6iOfSnqnqbGtKEcxcM7/PRWZOy9O4izzuUpwCQgzs16SKrNW+le4YzmReIKWV1H/1oJoBr6TGMdjKW5gTvl+9fp3QCJdpyVdPXKTTJAwlmm4HvWffs694BRBDnZsa0eTqhfp0yOne4wmJkRk7izH9QwRuutUpPVqu62YvEuwKfbiyvna5WtjVOjFe0LUV6kOvvqxtGQPN7D1p7PUB9yrG/k4a9f3JbWlzQf5w88HIvaM8DvkAsWddJwYoux0fXWsD3hwlgrG3Ge3LQC3mgkChmOjhNl+jWw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jcdNyv+N0qIm2d/1e8K99eto+vODSu12mYZDthIbpY4S5xoWSr+5td37sx4iBdKOVg71lctFe/g+Kp+NLnNaeNBfRUMM+JLgGFHPe2UTnCg3/Xj6fGxqj/zhsVziEe5tHkcUqVHj/pIQhoZyUzaKQJ6qgnLk328nedcHYLJljegM41m8bWTXp4zzKMBjKPWalPcXR8MCSOqJCdf94oJBZLRzCCQlqqpYZzr1gY5DiE/r566FlZIKkUJeY1Tt7JJT27gz5kaxRPTQlkLQ/NOsNGy2fQ1wp1RhVXiHZ7U4zTOvSQz5CSmq3pQuBj8mrX2Bb3PXGCuQqFRtZ6DE67NlKw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Delivery-date: Thu, 03 Aug 2023 20:39:05 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZxfetD3iMBVO78kiKHyDm3xOwK6/Y3kwAgAAfToCAAAsagA==
- Thread-topic: [PATCH v2 2/2] fdt: make fdt handling reusable across arch
>
>> Regarding the coding style, I think it’s better to keep the style you’ve
>> found in the original file,
>> and change only some bits when the code is not following it.
>> I know there is nothing enforcing parameters on the same line of the
>> function definition at the
>> moment, but it is how it’s done from the original file so I would stick with
>> it.
>> Regarding the u32/u64 types, maybe since you are moving the code it can be
>> the occasion to
>> convert them, but check with the maintainer before.
>
> I can leave the main code as is, but I do think header decl's should be
> styled correctly as there is no need to have them churn in the future over
> purely style changes.
Uhm, when you say “styled correctly” do you mean as below?
>>> +bool __init device_tree_node_matches(
>>> + const void *fdt, int node, const char *match)
>>> +{
If that’s the case, it seems to me that there is nothing like that in the
codebase,
in my work with clang-format I’ve configured it to match as much as I can the
Xen style and this function would be formatted as the old style that it had.
Can I ask you where did you find instruction to style in that way?
|
