[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v4 5/8] PPC: switch entry point annotations to common model


  • To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 4 Aug 2023 08:30:13 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R5BIsX4FSDC0bHsNPv5zyFFrdlOeD6u1F2sVkFP/hDk=; b=GCG6IOxZ/+3H5dB7nFMPA5uJ9Zybi1o3l8J076k3cAVpc9OtnnDAsStoRPd06ePxDQ2LimCwRHWx8vda5XAWSG/HoHv5aAT8UZold+xHpXV+U2USz+AAe+p1h6nOxokaHeRVlD2A4oyO93pIvo9VfeKwhQwPjhlIPRPhVQv/NSUuwxuknNk1RT/pUq3kkH8an4ZDOqFmk5SX4GMPaKyl1Mi0rHL8i1q3KdoxaGPNtEOMVtqwaJi6vH04Jhl+pzHhHVxOdCQgVrd74aZ7qK9oopd3A6zQXQbJ4k8/1W2kHv+lUa3A+HPMIpotn3exIcURSgLTLdT7k3jHo1obXSCqIQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gs04y2bRLoSOIC/O5daECMMYZc7FpA1V1x3wGUo1SAWv+j8Qv043wMdjgf2FGBYMnXhH3wSD9pbA/CI+u4DP1gdEtmr90MTVCrADqKDLaRC80mL68mnkkSLixnghX4cQCI6hqelY5X6L6niq4vTtYcw5J3laJ2/zIvJd3l9HkmOZDg0Hz8jIGtIhS6Q7k65y+V2sIE42ln74k8vmy6+rAQtTmI7u3FU/Mf2mL5BibHmfHwV03JcQUpaoipMH5r9wjNsHM3R3lbqw9fsjzS0kIpiYNpiaqAmntjvrafhg2WISjUQcMS9iFE/98MFrZBVceaLSyxsEM6ziDCQwC2/VVA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: George Dunlap <george.dunlap@xxxxxxxxxx>, Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Fri, 04 Aug 2023 06:30:18 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Use the generic framework in xen/linkage.h. No change in generated code
except of course the converted symbol changes to be a hidden one.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
---
v4: Also drop #undef-s from linker script. Re-base.
v3: New.

--- a/xen/arch/ppc/include/asm/asm-defns.h
+++ b/xen/arch/ppc/include/asm/asm-defns.h
@@ -2,6 +2,8 @@
 #ifndef _ASM_PPC_ASM_DEFNS_H
 #define _ASM_PPC_ASM_DEFNS_H
 
+#include <xen/linkage.h>
+
 /*
  * Load a 64-bit immediate value into the specified GPR.
  */
--- a/xen/arch/ppc/include/asm/config.h
+++ b/xen/arch/ppc/include/asm/config.h
@@ -31,12 +31,7 @@
 
 /* Linkage for PPC */
 #ifdef __ASSEMBLY__
-#define ALIGN .p2align 2
-
-#define ENTRY(name)                                                            
\
-    .globl name;                                                               
\
-    ALIGN;                                                                     
\
-    name:
+#define CODE_ALIGN 4
 #endif
 
 #define XEN_VIRT_START _AT(UL, 0xc000000000000000)
--- a/xen/arch/ppc/ppc64/head.S
+++ b/xen/arch/ppc/ppc64/head.S
@@ -5,7 +5,7 @@
 
     .section .text.header, "ax", %progbits
 
-ENTRY(start)
+FUNC(start)
     /*
      * NOTE: argument registers (r3-r9) must be preserved until the C 
entrypoint
      */
@@ -36,6 +36,4 @@ ENTRY(start)
 
     /* should never return */
     trap
-
-    .size start, . - start
-    .type start, %function
+END(start)
--- a/xen/arch/ppc/ppc64/of-call.S
+++ b/xen/arch/ppc/ppc64/of-call.S
@@ -23,7 +23,7 @@
 
     .section .init.text, "ax", @progbits
 
-ENTRY(enter_of)
+FUNC(enter_of)
     mflr    %r0
     std     %r0, 16(%r1)
     stdu    %r1, -STACK_SWITCH_FRAME_SIZE(%r1) /* Save SP and create stack 
space */
@@ -78,6 +78,4 @@ ENTRY(enter_of)
     ld      %r0, 16(%r1)
     mtlr    %r0
     blr
-
-    .size enter_of, . - enter_of
-    .type enter_of, %function
+END(enter_of)
--- a/xen/arch/ppc/xen.lds.S
+++ b/xen/arch/ppc/xen.lds.S
@@ -1,9 +1,6 @@
 #include <xen/lib.h>
 #include <xen/xen.lds.h>
 
-#undef ENTRY
-#undef ALIGN
-
 OUTPUT_ARCH(powerpc:common64)
 ENTRY(start)
 




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.