[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH] x86/mm: address violations of MISRA C:2012 Rules 8.2 and 8.3
On 04/08/23 11:05, Federico Serafini wrote:
Give a name to unnamed parameters to address violations of
MISRA C:2012 Rule 8.2 ("Function types shall be in prototype form with
named parameters").
Keep consistency between parameter names used in function
declarations and the ones used in the corresponding function
definitions, thus addressing violations of MISRA C:2012 Rule 8.3
("All declarations of an object or function shall use the same names
and type qualifiers").
No functional changes.
Signed-off-by: Federico Serafini <federico.serafini@xxxxxxxxxxx>
---
xen/arch/x86/include/asm/mm.h | 20 ++++++++++----------
xen/arch/x86/mm.c | 33 ++++++++++++++++++---------------
xen/include/xen/mm.h | 2 +-
3 files changed, 29 insertions(+), 26 deletions(-)
int xenmem_add_to_physmap_one(struct domain *d, unsigned int space,
union add_to_physmap_extra extra,
- unsigned long idx, gfn_t gfn);
+ unsigned long idx, gfn_t gpfn);
I am seeing now that this will cause a violation in the arm code,
I will propose a v2.
--
Federico Serafini, M.Sc.
Software Engineer, BUGSENG (http://bugseng.com)
|
